Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-24 Thread Hans Verkuil
On Wednesday, August 24, 2011 06:05:44 Pawel Osciak wrote: Hi, On Mon, Aug 22, 2011 at 23:31, Hans Verkuil hverk...@xs4all.nl wrote: On Monday, August 22, 2011 19:21:18 Laurent Pinchart wrote: Hi Hans, On Monday 22 August 2011 17:52:12 Hans Verkuil wrote: On Monday, August 22, 2011

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-23 Thread Hans Verkuil
On Monday, August 22, 2011 19:21:18 Laurent Pinchart wrote: Hi Hans, On Monday 22 August 2011 17:52:12 Hans Verkuil wrote: On Monday, August 22, 2011 17:42:36 Laurent Pinchart wrote: On Monday 22 August 2011 15:54:03 Guennadi Liakhovetski wrote: We discussed a bit more with Hans on

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-23 Thread Pawel Osciak
Hi, On Mon, Aug 22, 2011 at 23:31, Hans Verkuil hverk...@xs4all.nl wrote: On Monday, August 22, 2011 19:21:18 Laurent Pinchart wrote: Hi Hans, On Monday 22 August 2011 17:52:12 Hans Verkuil wrote: On Monday, August 22, 2011 17:42:36 Laurent Pinchart wrote: On Monday 22 August 2011

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-22 Thread Hans Verkuil
Sorry for starting this discussion and then disappearing. I've been very busy lately, so my apologies for that. On Tuesday, August 16, 2011 18:14:33 Pawel Osciak wrote: Hi Guennadi, On Tue, Aug 16, 2011 at 06:13, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 15 Aug 2011,

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-22 Thread Guennadi Liakhovetski
Hi Hans On Mon, 22 Aug 2011, Hans Verkuil wrote: Sorry for starting this discussion and then disappearing. I've been very busy lately, so my apologies for that. On Tuesday, August 16, 2011 18:14:33 Pawel Osciak wrote: Hi Guennadi, On Tue, Aug 16, 2011 at 06:13, Guennadi Liakhovetski

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-22 Thread Hans Verkuil
On Monday, August 22, 2011 12:40:25 Guennadi Liakhovetski wrote: Hi Hans On Mon, 22 Aug 2011, Hans Verkuil wrote: Sorry for starting this discussion and then disappearing. I've been very busy lately, so my apologies for that. On Tuesday, August 16, 2011 18:14:33 Pawel Osciak wrote:

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-22 Thread Guennadi Liakhovetski
We discussed a bit more with Hans on IRC, and below is my attempt of a summary. Hans, please, correct me, if I misunderstood anything. Pawel, Sakari, Laurent: please, reply, whether you're ok with this. On Mon, 22 Aug 2011, Hans Verkuil wrote: On Monday, August 22, 2011 12:40:25 Guennadi

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-22 Thread Hans Verkuil
On Monday, August 22, 2011 15:54:03 Guennadi Liakhovetski wrote: We discussed a bit more with Hans on IRC, and below is my attempt of a summary. Hans, please, correct me, if I misunderstood anything. Looks good, that's exactly what I meant. Regards, Hans Pawel, Sakari, Laurent:

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-22 Thread Laurent Pinchart
Hi Guennadi, On Monday 22 August 2011 15:54:03 Guennadi Liakhovetski wrote: We discussed a bit more with Hans on IRC, and below is my attempt of a summary. Hans, please, correct me, if I misunderstood anything. Pawel, Sakari, Laurent: please, reply, whether you're ok with this. Sakari is on

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-22 Thread Hans Verkuil
On Monday, August 22, 2011 17:42:36 Laurent Pinchart wrote: Hi Guennadi, On Monday 22 August 2011 15:54:03 Guennadi Liakhovetski wrote: We discussed a bit more with Hans on IRC, and below is my attempt of a summary. Hans, please, correct me, if I misunderstood anything. Pawel, Sakari,

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-22 Thread Laurent Pinchart
Hi Hans, On Monday 22 August 2011 17:52:12 Hans Verkuil wrote: On Monday, August 22, 2011 17:42:36 Laurent Pinchart wrote: On Monday 22 August 2011 15:54:03 Guennadi Liakhovetski wrote: We discussed a bit more with Hans on IRC, and below is my attempt of a summary. Hans, please, correct

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-17 Thread Guennadi Liakhovetski
On Sat, 6 Aug 2011, Sakari Ailus wrote: Guennadi Liakhovetski wrote: A possibility to preallocate and initialise buffers of different sizes in V4L2 is required for an efficient implementation of asnapshot mode. This patch adds two new ioctl()s: VIDIOC_CREATE_BUFS and VIDIOC_PREPARE_BUF

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-17 Thread Guennadi Liakhovetski
On Tue, 16 Aug 2011, Pawel Osciak wrote: Hi Guennadi, On Tue, Aug 16, 2011 at 06:13, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 15 Aug 2011, Guennadi Liakhovetski wrote: On Mon, 15 Aug 2011, Hans Verkuil wrote: On Monday, August 15, 2011 13:28:23 Guennadi

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-17 Thread Sakari Ailus
On Wed, Aug 17, 2011 at 10:41:51AM +0200, Guennadi Liakhovetski wrote: On Sat, 6 Aug 2011, Sakari Ailus wrote: Guennadi Liakhovetski wrote: A possibility to preallocate and initialise buffers of different sizes in V4L2 is required for an efficient implementation of asnapshot mode.

RE: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-17 Thread Marek Szyprowski
Hello, On Monday, August 15, 2011 3:46 PM Guennadi Liakhovetski wrote: On Mon, 15 Aug 2011, Hans Verkuil wrote: On Monday, August 15, 2011 13:28:23 Guennadi Liakhovetski wrote: On Mon, 8 Aug 2011, Hans Verkuil wrote: On Friday, August 05, 2011 09:47:13 Guennadi Liakhovetski wrote:

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-17 Thread Pawel Osciak
On Wed, Aug 17, 2011 at 06:22, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On Monday, August 15, 2011 3:46 PM Guennadi Liakhovetski wrote: While switching back, I have to change the struct vb2_ops::queue_setup() operation to take a struct v4l2_create_buffers pointer. An earlier

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-17 Thread Pawel Osciak
Hi On Wed, Aug 17, 2011 at 02:11, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Tue, 16 Aug 2011, Pawel Osciak wrote: Hi Guennadi, On Tue, Aug 16, 2011 at 06:13, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 15 Aug 2011, Guennadi Liakhovetski wrote: On Mon, 15 Aug

RE: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-17 Thread Marek Szyprowski
Hello, On Wednesday, August 17, 2011 4:58 PM Pawel Osciak wrote: On Wed, Aug 17, 2011 at 06:22, Marek Szyprowski m.szyprow...@samsung.com wrote: On Monday, August 15, 2011 3:46 PM Guennadi Liakhovetski wrote: While switching back, I have to change the struct vb2_ops::queue_setup()

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-16 Thread Guennadi Liakhovetski
On Mon, 15 Aug 2011, Guennadi Liakhovetski wrote: On Mon, 15 Aug 2011, Hans Verkuil wrote: On Monday, August 15, 2011 13:28:23 Guennadi Liakhovetski wrote: Hi Hans On Mon, 8 Aug 2011, Hans Verkuil wrote: [snip] but I've changed my mind: I think this should use a struct

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-16 Thread Pawel Osciak
Hi Guennadi, On Tue, Aug 16, 2011 at 06:13, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 15 Aug 2011, Guennadi Liakhovetski wrote: On Mon, 15 Aug 2011, Hans Verkuil wrote: On Monday, August 15, 2011 13:28:23 Guennadi Liakhovetski wrote: Hi Hans On Mon, 8 Aug 2011,

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-15 Thread Guennadi Liakhovetski
Hi Hans On Mon, 8 Aug 2011, Hans Verkuil wrote: Hi Guennadi! On Friday, August 05, 2011 09:47:13 Guennadi Liakhovetski wrote: A possibility to preallocate and initialise buffers of different sizes in V4L2 is required for an efficient implementation of asnapshot mode. This patch adds

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-15 Thread Hans Verkuil
On Monday, August 15, 2011 13:28:23 Guennadi Liakhovetski wrote: Hi Hans On Mon, 8 Aug 2011, Hans Verkuil wrote: Hi Guennadi! On Friday, August 05, 2011 09:47:13 Guennadi Liakhovetski wrote: A possibility to preallocate and initialise buffers of different sizes in V4L2 is

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-11 Thread Sakari Ailus
On Wed, Aug 10, 2011 at 08:25:24AM +0200, Hans Verkuil wrote: On Wednesday, August 10, 2011 01:37:27 Sakari Ailus wrote: On Tue, Aug 09, 2011 at 09:26:30AM +0200, Hans Verkuil wrote: ... Wouldn't that be a security issue ? Any application with permissions to access the video

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-10 Thread Hans Verkuil
On Wednesday, August 10, 2011 01:37:27 Sakari Ailus wrote: On Tue, Aug 09, 2011 at 09:26:30AM +0200, Hans Verkuil wrote: ... Wouldn't that be a security issue ? Any application with permissions to access the video device could DoS the system. How is this any different from an

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-09 Thread Hans Verkuil
On Tuesday, August 09, 2011 00:06:10 Laurent Pinchart wrote: Hi Hans, On Monday 08 August 2011 14:40:27 Hans Verkuil wrote: On Monday, August 08, 2011 13:40:23 Laurent Pinchart wrote: On Monday 08 August 2011 11:16:41 Hans Verkuil wrote: On Friday, August 05, 2011 09:47:13 Guennadi

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-08 Thread Sakari Ailus
Guennadi Liakhovetski wrote: A possibility to preallocate and initialise buffers of different sizes in V4L2 is required for an efficient implementation of asnapshot mode. This patch adds two new ioctl()s: VIDIOC_CREATE_BUFS and VIDIOC_PREPARE_BUF and defines respective data structures.

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-08 Thread Hans Verkuil
Hi Guennadi! On Friday, August 05, 2011 09:47:13 Guennadi Liakhovetski wrote: A possibility to preallocate and initialise buffers of different sizes in V4L2 is required for an efficient implementation of asnapshot mode. This patch adds two new ioctl()s: VIDIOC_CREATE_BUFS and

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-08 Thread Laurent Pinchart
On Monday 08 August 2011 11:16:41 Hans Verkuil wrote: On Friday, August 05, 2011 09:47:13 Guennadi Liakhovetski wrote: A possibility to preallocate and initialise buffers of different sizes in V4L2 is required for an efficient implementation of asnapshot mode. This patch adds two new

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-08 Thread Laurent Pinchart
Hi Hans, On Monday 08 August 2011 14:40:27 Hans Verkuil wrote: On Monday, August 08, 2011 13:40:23 Laurent Pinchart wrote: On Monday 08 August 2011 11:16:41 Hans Verkuil wrote: On Friday, August 05, 2011 09:47:13 Guennadi Liakhovetski wrote: A possibility to preallocate and initialise

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-08 Thread Sakari Ailus
Laurent Pinchart wrote: Hi Hans, On Monday 08 August 2011 14:40:27 Hans Verkuil wrote: On Monday, August 08, 2011 13:40:23 Laurent Pinchart wrote: On Monday 08 August 2011 11:16:41 Hans Verkuil wrote: On Friday, August 05, 2011 09:47:13 Guennadi Liakhovetski wrote: A possibility to

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-06 Thread Pawel Osciak
Hi Guennadi, On Fri, Aug 5, 2011 at 00:47, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: A possibility to preallocate and initialise buffers of different sizes in V4L2 is required for an efficient implementation of asnapshot mode. This patch adds two new ioctl()s: VIDIOC_CREATE_BUFS and

[PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

2011-08-05 Thread Guennadi Liakhovetski
A possibility to preallocate and initialise buffers of different sizes in V4L2 is required for an efficient implementation of asnapshot mode. This patch adds two new ioctl()s: VIDIOC_CREATE_BUFS and VIDIOC_PREPARE_BUF and defines respective data structures. Signed-off-by: Guennadi Liakhovetski