Re: [PATCH 17/21] workqueue: simple reimplementation of SINGLE_THREAD workqueue

2009-11-17 Thread Linus Torvalds
On Wed, 18 Nov 2009, Tejun Heo wrote: > > I might have been too early with the 'easy' part but I definitely can > give it a shot. What do you think about the scheduler notifier > implementation? It seems we'll end up with three callbacks. It can > either be three hlist_heads in the struct_tas

Re: [PATCH 17/21] workqueue: simple reimplementation of SINGLE_THREAD workqueue

2009-11-17 Thread Tejun Heo
Hello, 11/17/2009 09:05 PM, Andy Walls wrote: >> Implementing strict ordering >> shouldn't be too difficult but I can't help but feeling that such >> assumption is abuse of implementation detail. > > Hmmm, does not the "queue" in workqueue mean "FIFO"? I don't think it necessarily means strict

Re: [PATCH 17/21] workqueue: simple reimplementation of SINGLE_THREAD workqueue

2009-11-17 Thread Tejun Heo
Hello, Linus. 11/18/2009 12:05 AM, Linus Torvalds wrote: >> Do you think that usage is wide-spread? Implementing strict ordering >> shouldn't be too difficult but I can't help but feeling that such >> assumption is abuse of implementation detail. > > I think it would be good if it were more than

Re: [PATCH 17/21] workqueue: simple reimplementation of SINGLE_THREAD workqueue

2009-11-17 Thread Linus Torvalds
On Tue, 17 Nov 2009, Tejun Heo wrote: > > Do you think that usage is wide-spread? Implementing strict ordering > shouldn't be too difficult but I can't help but feeling that such > assumption is abuse of implementation detail. I think it would be good if it were more than an implementation deta

Re: [PATCH 17/21] workqueue: simple reimplementation of SINGLE_THREAD workqueue

2009-11-17 Thread Andy Walls
On Tue, 2009-11-17 at 14:23 +0900, Tejun Heo wrote: > Hello, > > 11/17/2009 09:47 AM, Andy Walls wrote: > > An important property of the single threaded workqueue, upon which the > > cx18 driver relies, is that work objects will be processed strictly in > > the order in which they were queued. Th

Re: [PATCH 17/21] workqueue: simple reimplementation of SINGLE_THREAD workqueue

2009-11-16 Thread Tejun Heo
Hello, 11/17/2009 09:47 AM, Andy Walls wrote: > An important property of the single threaded workqueue, upon which the > cx18 driver relies, is that work objects will be processed strictly in > the order in which they were queued. The cx18 driver has a pool of > "work orders" and multiple active

Re: [PATCH 17/21] workqueue: simple reimplementation of SINGLE_THREAD workqueue

2009-11-16 Thread Andy Walls
On Tue, 2009-11-17 at 02:15 +0900, Tejun Heo wrote: > SINGLE_THREAD workqueues are used to reduce the number of worker > threads and ease synchronization. The first reason will be irrelevant > with concurrency managed workqueue implementation. Simplify > SINGLE_THREAD implementation by creating t