Em 05-07-2012 11:31, Devin Heitmueller escreveu:
> On Thu, Jul 5, 2012 at 10:25 AM, Devin Heitmueller
> wrote:
>> On Thu, Jul 5, 2012 at 10:16 AM, Mauro Carvalho Chehab
>>> - /* Use both frq_lock and signal to generate the result */
>>> - signal = signal || ((signal & 0x07) << 12);
>>>
On Thu, Jul 5, 2012 at 10:25 AM, Devin Heitmueller
wrote:
> On Thu, Jul 5, 2012 at 10:16 AM, Mauro Carvalho Chehab
>> - /* Use both frq_lock and signal to generate the result */
>> - signal = signal || ((signal & 0x07) << 12);
>> + /* Signal level is 3 bits only */
>> +
>> +
On Thu, Jul 5, 2012 at 10:16 AM, Mauro Carvalho Chehab
> - /* Use both frq_lock and signal to generate the result */
> - signal = signal || ((signal & 0x07) << 12);
> + /* Signal level is 3 bits only */
> +
> + signal = ((1 << 12) - 1) | ((signal & 0x07) << 12);
Are you sur
There are several bugs at the signal strength algorithm:
- It is using logical OR, instead of bit OR;
- It doesn't wait up to 18 ms as it should;
- the strength range is not ok.
Rework on it, in order to make it work.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/med
