Re: [PATCH 2/3] radio-si470x: move some file operations to common file

2009-12-01 Thread Tobias Lorenz
Hi, yes, good point. Acked-by: Tobias Lorenz Bye, Toby Am Mittwoch 18 November 2009 07:21:30 schrieb Joonyoung Shim: > The read and poll file operations of the si470x usb driver can be used > also equally on the si470x i2c driver, so they go to the common file. > > Signed-off-by: Joonyoung Sh

Re: [PATCH 2/3] radio-si470x: move some file operations to common file

2009-11-17 Thread Hans Verkuil
On Wednesday 18 November 2009 07:42:41 Hans Verkuil wrote: > On Wednesday 18 November 2009 07:21:30 Joonyoung Shim wrote: > > The read and poll file operations of the si470x usb driver can be used > > also equally on the si470x i2c driver, so they go to the common file. > > > > Signed-off-by: Joon

Re: [PATCH 2/3] radio-si470x: move some file operations to common file

2009-11-17 Thread Hans Verkuil
On Wednesday 18 November 2009 07:21:30 Joonyoung Shim wrote: > The read and poll file operations of the si470x usb driver can be used > also equally on the si470x i2c driver, so they go to the common file. > > Signed-off-by: Joonyoung Shim Why on earth is the i2c driver registering a radio devic

[PATCH 2/3] radio-si470x: move some file operations to common file

2009-11-17 Thread Joonyoung Shim
The read and poll file operations of the si470x usb driver can be used also equally on the si470x i2c driver, so they go to the common file. Signed-off-by: Joonyoung Shim --- drivers/media/radio/si470x/radio-si470x-common.c | 98 ++ drivers/media/radio/si470x/radio-si470x-i