subject:"\[PATCH 2\/6\] media\: dvb_frontend\: cleanup ioctl handling logic"

Re: [PATCH 2/6] media: dvb_frontend: cleanup ioctl handling logic

2017-09-20 Thread Mauro Carvalho Chehab

Em Wed, 20 Sep 2017 14:58:12 -0600 Shuah Khan escreveu: > > + c->state = DTV_UNDEFINED;> +err = dvb_frontend_handle_ioctl(file, > > cmd, parg); > > With this change, c->state value gets changed unconditionally before > calling the ioctl. > >

Re: [PATCH 2/6] media: dvb_frontend: cleanup ioctl handling logic

2017-09-20 Thread Shuah Khan

H Mauro, On 09/19/2017 07:42 AM, Mauro Carvalho Chehab wrote: > Currently, there are two handlers for ioctls: > - dvb_frontend_ioctl_properties() > - dvb_frontend_ioctl_legacy() > > Despite their names, both handles non-legacy DVB ioctls. > > Besides that, there's no reason why to not handle

[PATCH 2/6] media: dvb_frontend: cleanup ioctl handling logic

2017-09-19 Thread Mauro Carvalho Chehab

Currently, there are two handlers for ioctls: - dvb_frontend_ioctl_properties() - dvb_frontend_ioctl_legacy() Despite their names, both handles non-legacy DVB ioctls. Besides that, there's no reason why to not handle all ioctls on a single handler function. So, merge them into a single