Laurent Pinchart wrote:
Hi Sakari,
On Tuesday 24 April 2012 18:14:20 Sakari Ailus wrote:
On Tue, Apr 24, 2012 at 11:08:12AM +0200, Laurent Pinchart wrote:
On Tuesday 24 April 2012 01:23:06 Sakari Ailus wrote:
Hi Laurent,
The patch looks good as such on the first glance, but I have another
qu
Hi Sakari,
On Tuesday 24 April 2012 18:14:20 Sakari Ailus wrote:
> On Tue, Apr 24, 2012 at 11:08:12AM +0200, Laurent Pinchart wrote:
> > On Tuesday 24 April 2012 01:23:06 Sakari Ailus wrote:
> > > Hi Laurent,
> > >
> > > The patch looks good as such on the first glance, but I have another
> > > q
Hi Laurent,
On Tue, Apr 24, 2012 at 11:08:12AM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Tuesday 24 April 2012 01:23:06 Sakari Ailus wrote:
> > Hi Laurent,
> >
> > The patch looks good as such on the first glance, but I have another
> > question: why are you not using the selections API
Hi Sakari,
On Tuesday 24 April 2012 01:23:06 Sakari Ailus wrote:
> Hi Laurent,
>
> The patch looks good as such on the first glance, but I have another
> question: why are you not using the selections API instead? It's in
> Mauro's tree already.
You're totally right, we need to convert the selec
Hi Laurent,
The patch looks good as such on the first glance, but I have another
question: why are you not using the selections API instead? It's in
Mauro's tree already. Also, the old S_CROP IOCTL only has been defined
for sink pads, not source.
Cheers,
--
Sakari Ailus
sakari.ai...@iki.fi
Signed-off-by: Laurent Pinchart
---
drivers/media/video/omap3isp/ispccdc.c | 147 +---
drivers/media/video/omap3isp/ispccdc.h |2 +
2 files changed, 136 insertions(+), 13 deletions(-)
diff --git a/drivers/media/video/omap3isp/ispccdc.c
b/drivers/media/video/omap
