Re: [PATCH 3/4] soc-camera: add support for camera-host controls

2009-06-12 Thread Guennadi Liakhovetski
On Fri, 12 Jun 2009, Dongsoo, Nathaniel Kim wrote: Hello Guennadi, So let's assume that camera interface device can process V4L2_CID_SHARPNESS and even external camera device can process that, then according to your patch both of camera interface and external camera device can be issued to

Re: [PATCH 3/4] soc-camera: add support for camera-host controls

2009-06-12 Thread Dongsoo, Nathaniel Kim
On Fri, Jun 12, 2009 at 3:30 PM, Guennadi Liakhovetskig.liakhovet...@gmx.de wrote: On Fri, 12 Jun 2009, Dongsoo, Nathaniel Kim wrote: Hello Guennadi, So let's assume that camera interface device can process V4L2_CID_SHARPNESS and even external camera device can process that, then according

[PATCH 3/4] soc-camera: add support for camera-host controls

2009-06-11 Thread Guennadi Liakhovetski
Until now soc-camera only supported client (sensor) controls. This patch enables camera-host drivers to implement their own controls too. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/video/soc_camera.c | 24 include/media/soc_camera.h

Re: [PATCH 3/4] soc-camera: add support for camera-host controls

2009-06-11 Thread Dongsoo, Nathaniel Kim
Hello Guennadi, It's a very interesting patch. Actually some camera interfaces support for various image effects and I was wondering how to use them in SoC camera subsystem. But here is a question. Is it possible to make a choice with the same CID between icd and ici? I mean, if both of camera

Re: [PATCH 3/4] soc-camera: add support for camera-host controls

2009-06-11 Thread Dongsoo, Nathaniel Kim
Hello Guennadi, So let's assume that camera interface device can process V4L2_CID_SHARPNESS and even external camera device can process that, then according to your patch both of camera interface and external camera device can be issued to process V4L2_CID_SHARPNESS which I guess will make image