Re: [alsa-devel] [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-12-18 Thread Tim Harvey
On Sat, Dec 16, 2017 at 11:32 AM, Fabio Estevam wrote: > Hi Tim, > > On Thu, Nov 9, 2017 at 4:45 PM, Tim Harvey wrote: > >> +static int tda1997x_set_power(struct tda1997x_state *state, bool on) >> +{ >> + int ret = 0; >> + >> + if (on) { >> + ret = regulator_bulk_enable(

Re: [alsa-devel] [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-12-16 Thread Fabio Estevam
Hi Tim, On Thu, Nov 9, 2017 at 4:45 PM, Tim Harvey wrote: > +static int tda1997x_set_power(struct tda1997x_state *state, bool on) > +{ > + int ret = 0; > + > + if (on) { > + ret = regulator_bulk_enable(TDA1997X_NUM_SUPPLIES, > +

Re: [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-12-14 Thread Hans Verkuil
On 14/12/17 00:33, Tim Harvey wrote: > On Tue, Dec 12, 2017 at 4:18 AM, Hans Verkuil wrote: >> Hi Tim, >> >> Sorry for the delay, I needed to find some time to think about this. >> >> On 11/16/17 05:30, Rob Herring wrote: >>> On Wed, Nov 15, 2017 at 10:31:14AM -0800, Tim Harvey wrote: On Wed,

Re: [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-12-13 Thread Tim Harvey
On Tue, Dec 12, 2017 at 4:18 AM, Hans Verkuil wrote: > Hi Tim, > > Sorry for the delay, I needed to find some time to think about this. > > On 11/16/17 05:30, Rob Herring wrote: >> On Wed, Nov 15, 2017 at 10:31:14AM -0800, Tim Harvey wrote: >>> On Wed, Nov 15, 2017 at 7:52 AM, Rob Herring wrote:

Re: [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-12-12 Thread Hans Verkuil
Hi Tim, Sorry for the delay, I needed to find some time to think about this. On 11/16/17 05:30, Rob Herring wrote: > On Wed, Nov 15, 2017 at 10:31:14AM -0800, Tim Harvey wrote: >> On Wed, Nov 15, 2017 at 7:52 AM, Rob Herring wrote: >>> On Thu, Nov 09, 2017 at 10:45:34AM -0800, Tim Harvey wrote:

Re: [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-29 Thread Tim Harvey
On Thu, Nov 23, 2017 at 12:08 AM, Hans Verkuil wrote: > On 11/23/2017 05:27 AM, Tim Harvey wrote: >> On Mon, Nov 20, 2017 at 7:39 AM, Hans Verkuil wrote: >>> Hi Tim, >>> >>> Some more review comments: >>> >>> On 11/09/2017 07:45 PM, Tim Harvey wrote: Add support for the TDA1997x HDMI receive

Re: [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-23 Thread Hans Verkuil
On 11/23/2017 05:27 AM, Tim Harvey wrote: > On Mon, Nov 20, 2017 at 7:39 AM, Hans Verkuil wrote: >> Hi Tim, >> >> Some more review comments: >> >> On 11/09/2017 07:45 PM, Tim Harvey wrote: >>> Add support for the TDA1997x HDMI receivers. > >>> + */ >>> +struct color_matrix_coefs { >>> + const

Re: [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-22 Thread Tim Harvey
On Wed, Nov 15, 2017 at 8:30 PM, Rob Herring wrote: > On Wed, Nov 15, 2017 at 10:31:14AM -0800, Tim Harvey wrote: >> On Wed, Nov 15, 2017 at 7:52 AM, Rob Herring wrote: >> > On Thu, Nov 09, 2017 at 10:45:34AM -0800, Tim Harvey wrote: >> >> Add support for the TDA1997x HDMI receivers. >> >> >> >>

Re: [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-22 Thread Tim Harvey
On Mon, Nov 20, 2017 at 7:39 AM, Hans Verkuil wrote: > Hi Tim, > > Some more review comments: > > On 11/09/2017 07:45 PM, Tim Harvey wrote: >> Add support for the TDA1997x HDMI receivers. >> + */ >> +struct color_matrix_coefs { >> + const char *name; >> + /* Input offsets */ >> + s16

Re: [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-20 Thread Hans Verkuil
Hi Tim, Some more review comments: On 11/09/2017 07:45 PM, Tim Harvey wrote: > Add support for the TDA1997x HDMI receivers. > > Cc: Hans Verkuil > Signed-off-by: Tim Harvey > --- > v3: > - use V4L2_DV_BT_FRAME_WIDTH/HEIGHT macros > - fixed missing break > - use only hdmi_infoframe_log for i

Re: [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-15 Thread Rob Herring
On Wed, Nov 15, 2017 at 10:31:14AM -0800, Tim Harvey wrote: > On Wed, Nov 15, 2017 at 7:52 AM, Rob Herring wrote: > > On Thu, Nov 09, 2017 at 10:45:34AM -0800, Tim Harvey wrote: > >> Add support for the TDA1997x HDMI receivers. > >> > >> Cc: Hans Verkuil > >> Signed-off-by: Tim Harvey > >> --- >

Re: [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-15 Thread Tim Harvey
On Wed, Nov 15, 2017 at 7:52 AM, Rob Herring wrote: > On Thu, Nov 09, 2017 at 10:45:34AM -0800, Tim Harvey wrote: >> Add support for the TDA1997x HDMI receivers. >> >> Cc: Hans Verkuil >> Signed-off-by: Tim Harvey >> --- >> v3: >> - use V4L2_DV_BT_FRAME_WIDTH/HEIGHT macros >> - fixed missing b

Re: [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-15 Thread Rob Herring
On Thu, Nov 09, 2017 at 10:45:34AM -0800, Tim Harvey wrote: > Add support for the TDA1997x HDMI receivers. > > Cc: Hans Verkuil > Signed-off-by: Tim Harvey > --- > v3: > - use V4L2_DV_BT_FRAME_WIDTH/HEIGHT macros > - fixed missing break > - use only hdmi_infoframe_log for infoframe logging >

[PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-09 Thread Tim Harvey
Add support for the TDA1997x HDMI receivers. Cc: Hans Verkuil Signed-off-by: Tim Harvey --- v3: - use V4L2_DV_BT_FRAME_WIDTH/HEIGHT macros - fixed missing break - use only hdmi_infoframe_log for infoframe logging - simplify tda1997x_s_stream error handling - add delayed work proc to handle