Re: [PATCH 3/5] uvc gadget: switch to unlocked_ioctl.

2015-02-16 Thread Laurent Pinchart
Hi Hans, On Monday 16 February 2015 16:11:55 Hans Verkuil wrote: > On 02/03/2015 02:55 PM, Laurent Pinchart wrote: > > On Tuesday 03 February 2015 13:47:24 Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Instead of .ioctl use unlocked_ioctl. While all the queue ops > >> already use a lock,

Re: [PATCH 3/5] uvc gadget: switch to unlocked_ioctl.

2015-02-16 Thread Hans Verkuil
On 02/03/2015 02:55 PM, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Tuesday 03 February 2015 13:47:24 Hans Verkuil wrote: >> From: Hans Verkuil >> >> Instead of .ioctl use unlocked_ioctl. While all the queue ops >> already use a lock, there was no lock to protect uvc_v

Re: [PATCH 3/5] uvc gadget: switch to unlocked_ioctl.

2015-02-03 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Tuesday 03 February 2015 13:47:24 Hans Verkuil wrote: > From: Hans Verkuil > > Instead of .ioctl use unlocked_ioctl. While all the queue ops > already use a lock, there was no lock to protect uvc_video, so > add that one. There's more. streamon and streamof

[PATCH 3/5] uvc gadget: switch to unlocked_ioctl.

2015-02-03 Thread Hans Verkuil
From: Hans Verkuil Instead of .ioctl use unlocked_ioctl. While all the queue ops already use a lock, there was no lock to protect uvc_video, so add that one. Signed-off-by: Hans Verkuil --- drivers/usb/gadget/function/f_uvc.c| 1 + drivers/usb/gadget/function/uvc.h | 1 + drivers/usb/