Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

2017-05-08 Thread Steve Longerbeam
On 05/08/2017 02:41 AM, Philipp Zabel wrote: Hi Steve, On Wed, 2017-04-12 at 17:45 -0700, Steve Longerbeam wrote: This patch adds a call to imx_media_fill_empty_mbus_fields() in the *_try_fmt() functions at the sink pads, to set empty field order and colorimetry parameters. If the field

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

2017-05-08 Thread Philipp Zabel
Hi Steve, On Wed, 2017-04-12 at 17:45 -0700, Steve Longerbeam wrote: > This patch adds a call to imx_media_fill_empty_mbus_fields() in the > *_try_fmt() functions at the sink pads, to set empty field order and > colorimetry parameters. > > If the field order is set to ANY, choose the currently

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

2017-04-18 Thread Philipp Zabel
On Thu, 2017-04-13 at 09:40 -0700, Steve Longerbeam wrote: [...] > >> @@ -804,12 +804,29 @@ static void prp_try_fmt(struct prp_priv *priv, > >> >format.height, > >> infmt->height / 4, MAX_H_SRC, > >>

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

2017-04-13 Thread Steve Longerbeam
On 04/13/2017 03:09 AM, Philipp Zabel wrote: Hi Steve, thanks for cleaning this up. Apart from the comments below, this looks good to me. On Wed, 2017-04-12 at 17:45 -0700, Steve Longerbeam wrote: This patch adds a call to imx_media_fill_empty_mbus_fields() in the *_try_fmt() functions at

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

2017-04-13 Thread Philipp Zabel
Hi Steve, thanks for cleaning this up. Apart from the comments below, this looks good to me. On Wed, 2017-04-12 at 17:45 -0700, Steve Longerbeam wrote: > This patch adds a call to imx_media_fill_empty_mbus_fields() in the > *_try_fmt() functions at the sink pads, to set empty field order and >

[PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

2017-04-12 Thread Steve Longerbeam
This patch adds a call to imx_media_fill_empty_mbus_fields() in the *_try_fmt() functions at the sink pads, to set empty field order and colorimetry parameters. If the field order is set to ANY, choose the currently set field order at the sink pad. If the colorspace is set to DEFAULT, choose the