Re: [PATCH 5/12] tm6000: update init table and sequence for tm6010

2010-02-10 Thread Stefan Ringel
Am 08.02.2010 12:21, schrieb Mauro Carvalho Chehab: At the above, you're just trying to reproduce whatever the original driver does, instead of relying on the i2c drivers. At the Linux drivers, we don't just send random i2c sequences in the middle of the setup. Instead, we let each i2c

Re: [PATCH 5/12] tm6000: update init table and sequence for tm6010

2010-02-10 Thread Mauro Carvalho Chehab
Stefan Ringel wrote: Am 08.02.2010 12:21, schrieb Mauro Carvalho Chehab: At the above, you're just trying to reproduce whatever the original driver does, instead of relying on the i2c drivers. At the Linux drivers, we don't just send random i2c sequences in the middle of the setup.

Re: [PATCH 5/12] tm6000: update init table and sequence for tm6010

2010-02-08 Thread Mauro Carvalho Chehab
Mauro Carvalho Chehab wrote: +tm6000_read_write_usb (dev, 0xc0, 0x10, 0x7f1f, 0x, buf, 2); Most of the calls there are read (0xc0). I don't know any device that requires a read for it to work. I suspect that the above code is just probing to check what i2c devices are found at

Re: [PATCH 5/12] tm6000: update init table and sequence for tm6010

2010-02-08 Thread Stefan Ringel
Am 08.02.2010 12:37, schrieb Mauro Carvalho Chehab: Mauro Carvalho Chehab wrote: + tm6000_read_write_usb (dev, 0xc0, 0x10, 0x7f1f, 0x, buf, 2); Most of the calls there are read (0xc0). I don't know any device that requires a read for it to work. I suspect that

Re: [PATCH 5/12] tm6000: update init table and sequence for tm6010

2010-02-08 Thread Mauro Carvalho Chehab
Stefan Ringel wrote: Am 08.02.2010 12:37, schrieb Mauro Carvalho Chehab: Mauro Carvalho Chehab wrote: + tm6000_read_write_usb (dev, 0xc0, 0x10, 0x7f1f, 0x, buf, 2); Most of the calls there are read (0xc0). I don't know any device that requires a read for it to

Re: [PATCH 5/12] tm6000: update init table and sequence for tm6010

2010-02-08 Thread Stefan Ringel
Am 08.02.2010 12:21, schrieb Mauro Carvalho Chehab: Hi Stefan, First, a few comments about your patch series: I've committed almost of your patches, and added an extra patch to make the driver to compile it with -git. There were other broken things when compiling against -git. Several of

Re: [PATCH 5/12] tm6000: update init table and sequence for tm6010

2010-02-08 Thread Stefan Ringel
Am 08.02.2010 18:29, schrieb Mauro Carvalho Chehab: Stefan Ringel wrote: Am 08.02.2010 12:37, schrieb Mauro Carvalho Chehab: Mauro Carvalho Chehab wrote: + tm6000_read_write_usb (dev, 0xc0, 0x10, 0x7f1f, 0x, buf, 2); Most of

Re: [PATCH 5/12] tm6000: update init table and sequence for tm6010

2010-02-08 Thread Stefan Ringel
Am 08.02.2010 18:34, schrieb Stefan Ringel: Am 08.02.2010 18:29, schrieb Mauro Carvalho Chehab: Stefan Ringel wrote: Am 08.02.2010 12:37, schrieb Mauro Carvalho Chehab: Mauro Carvalho Chehab wrote: +tm6000_read_write_usb (dev,

Re: [PATCH 5/12] tm6000: update init table and sequence for tm6010

2010-02-08 Thread Mauro Carvalho Chehab
Stefan Ringel wrote: Am 08.02.2010 18:34, schrieb Stefan Ringel: Am 08.02.2010 18:29, schrieb Mauro Carvalho Chehab: Stefan Ringel wrote: Am 08.02.2010 12:37, schrieb Mauro Carvalho Chehab: Mauro Carvalho Chehab wrote: +

Re: [PATCH 5/12] tm6000: update init table and sequence for tm6010

2010-02-08 Thread Mauro Carvalho Chehab
Stefan Ringel wrote: Am 08.02.2010 12:21, schrieb Mauro Carvalho Chehab: Hi Stefan, First, a few comments about your patch series: I've committed almost of your patches, and added an extra patch to make the driver to compile it with -git. There were other broken things when compiling

Re: [PATCH 5/12] tm6000: update init table and sequence for tm6010

2010-02-08 Thread Stefan Ringel
Am 08.02.2010 19:14, schrieb Mauro Carvalho Chehab: Stefan Ringel wrote: Am 08.02.2010 12:21, schrieb Mauro Carvalho Chehab: Hi Stefan, First, a few comments about your patch series: I've committed almost of your patches, and added an extra patch to make the driver to compile it

Re: [PATCH 5/12] tm6000: update init table and sequence for tm6010

2010-02-08 Thread Mauro Carvalho Chehab
Stefan Ringel wrote: Am 08.02.2010 19:14, schrieb Mauro Carvalho Chehab: Stefan Ringel wrote: We'll need some function to change between analog and digital modes, doing the right GPIO changes. See em28xx_set_mode() for a way of implementing it. I don't mean that. I mean it

[PATCH 5/12] tm6000: update init table and sequence for tm6010

2010-02-05 Thread stefan . ringel
From: Stefan Ringel stefan.rin...@arcor.de --- drivers/staging/tm6000/tm6000-core.c | 179 -- 1 files changed, 128 insertions(+), 51 deletions(-) diff --git a/drivers/staging/tm6000/tm6000-core.c b/drivers/staging/tm6000/tm6000-core.c index 7ec13d5..a2e2af5

[PATCH 5/12] tm6000: update init table and sequence for tm6010

2010-02-05 Thread stefan . ringel
From: Stefan Ringel stefan.rin...@arcor.de Signed-off-by: Stefan Ringel stefan.rin...@arcor.de --- drivers/staging/tm6000/tm6000-core.c | 179 -- 1 files changed, 128 insertions(+), 51 deletions(-) diff --git a/drivers/staging/tm6000/tm6000-core.c