Re: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

2017-06-15 Thread Sebastian Reichel
Hi, On Thu, Jun 15, 2017 at 03:32:10PM +0300, Sakari Ailus wrote: > On Thu, Jun 15, 2017 at 11:24:26AM +0200, Sebastian Reichel wrote: > > On Wed, Jun 14, 2017 at 12:47:16PM +0300, Sakari Ailus wrote: > > > None of the flash operations are not mandatory and therefore there should > > > be no need

Re: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

2017-06-15 Thread Sakari Ailus
On Thu, Jun 15, 2017 at 11:24:26AM +0200, Sebastian Reichel wrote: > Hi, > > On Wed, Jun 14, 2017 at 12:47:16PM +0300, Sakari Ailus wrote: > > None of the flash operations are not mandatory and therefore there should > > be no need for the flash ops structure either. Accept NULL. > > I think you

Re: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

2017-06-15 Thread Jacek Anaszewski
Hi Sakari, On 06/14/2017 11:19 PM, Sakari Ailus wrote: > Hi Jacek, > > On Wed, Jun 14, 2017 at 11:14:13PM +0200, Jacek Anaszewski wrote: >> Hi Sakari, >> >> On 06/14/2017 11:47 AM, Sakari Ailus wrote: >>> None of the flash operations are not mandatory and therefore there should >>> be no need for

Re: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

2017-06-15 Thread Sebastian Reichel
Hi, On Wed, Jun 14, 2017 at 12:47:16PM +0300, Sakari Ailus wrote: > None of the flash operations are not mandatory and therefore there should > be no need for the flash ops structure either. Accept NULL. I think you negated one time too much :). Otherwise: Reviewed-by: Sebastian Reichel -- Seb

Re: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

2017-06-14 Thread Sakari Ailus
Hi Jacek, On Wed, Jun 14, 2017 at 11:14:13PM +0200, Jacek Anaszewski wrote: > Hi Sakari, > > On 06/14/2017 11:47 AM, Sakari Ailus wrote: > > None of the flash operations are not mandatory and therefore there should > > be no need for the flash ops structure either. Accept NULL. > > > > Signed-of

Re: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

2017-06-14 Thread Jacek Anaszewski
Hi Sakari, On 06/14/2017 11:47 AM, Sakari Ailus wrote: > None of the flash operations are not mandatory and therefore there should > be no need for the flash ops structure either. Accept NULL. > > Signed-off-by: Sakari Ailus > --- > drivers/media/v4l2-core/v4l2-flash-led-class.c | 4 ++-- > 1 f

[PATCH 5/8] v4l2-flash: Flash ops aren't mandatory

2017-06-14 Thread Sakari Ailus
None of the flash operations are not mandatory and therefore there should be no need for the flash ops structure either. Accept NULL. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-flash-led-class.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/med