Re: [PATCH 6/6] media/platform: fix querycap

2014-11-25 Thread Jacek Anaszewski
Hi Hans, Thanks for the patch. On 11/24/2014 10:37 AM, Hans Verkuil wrote: From: Hans Verkuil Querycap shouldn't set the version field (the core does that for you), but it should set the device_caps field. In addition, remove the CAPTURE and OUTPUT caps for M2M devices. These were already sl

Re: [PATCH 6/6] media/platform: fix querycap

2014-11-25 Thread Prabhakar Lad
Hi Hans, Thanks for the patch. On Mon, Nov 24, 2014 at 9:37 AM, Hans Verkuil wrote: > From: Hans Verkuil > > Querycap shouldn't set the version field (the core does that for you), > but it should set the device_caps field. > > In addition, remove the CAPTURE and OUTPUT caps for M2M devices. The

RE: [PATCH 6/6] media/platform: fix querycap

2014-11-25 Thread Kamil Debski
Hi Hans, Thanks for this patch. Looks good. Best regards, Kamil > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: Monday, November 24, 2014 10:37 AM > To: linux-media@vger.kernel.org > Cc: Hans Verkuil; Lad, Prabhakar; Kamil Debski; Jacek Anaszewski > Subject: [PATCH 6/6]

[PATCH 6/6] media/platform: fix querycap

2014-11-24 Thread Hans Verkuil
From: Hans Verkuil Querycap shouldn't set the version field (the core does that for you), but it should set the device_caps field. In addition, remove the CAPTURE and OUTPUT caps for M2M devices. These were already slated for removal, so it's time to do so. Signed-off-by: Hans Verkuil Cc: Lad,