Re: [PATCH 7/7] [media] adv7180: Add support for power down

2014-03-10 Thread Lars-Peter Clausen
On 03/10/2014 04:28 PM, Hans Verkuil wrote: On 03/10/2014 04:24 PM, Lars-Peter Clausen wrote: On 03/10/2014 03:37 PM, Hans Verkuil wrote: [...] + +static int adv7180_s_power(struct v4l2_subdev *sd, int on) +{ + struct adv7180_state *state = to_state(sd); + struct i2c_client *client

Re: [PATCH 7/7] [media] adv7180: Add support for power down

2014-03-10 Thread Hans Verkuil
On 03/10/2014 04:24 PM, Lars-Peter Clausen wrote: > On 03/10/2014 03:37 PM, Hans Verkuil wrote: > [...] >>> + >>> +static int adv7180_s_power(struct v4l2_subdev *sd, int on) >>> +{ >>> + struct adv7180_state *state = to_state(sd); >>> + struct i2c_client *client = v4l2_get_subdevdata(sd); >>> +

Re: [PATCH 7/7] [media] adv7180: Add support for power down

2014-03-10 Thread Lars-Peter Clausen
On 03/10/2014 03:37 PM, Hans Verkuil wrote: [...] + +static int adv7180_s_power(struct v4l2_subdev *sd, int on) +{ + struct adv7180_state *state = to_state(sd); + struct i2c_client *client = v4l2_get_subdevdata(sd); + int ret; + + ret = mutex_lock_interruptible(&state->mut

Re: [PATCH 7/7] [media] adv7180: Add support for power down

2014-03-10 Thread Hans Verkuil
Hi Lars-Peter, See some comments below: On 03/07/2014 05:14 PM, Lars-Peter Clausen wrote: > The adv7180 has a low power mode in which the analog and the digital > processing > section are shut down. Implement the s_power callback to let bridge drivers > put > the part into low power mode when n

[PATCH 7/7] [media] adv7180: Add support for power down

2014-03-07 Thread Lars-Peter Clausen
The adv7180 has a low power mode in which the analog and the digital processing section are shut down. Implement the s_power callback to let bridge drivers put the part into low power mode when not needed. Signed-off-by: Lars-Peter Clausen --- drivers/media/i2c/adv7180.c | 52 +++