Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Brad Love
Hi Jasmin, On 2018-05-11 16:43, Jasmin J. wrote: > Hello Brad! > > THX for this clarification! > > So you tried already to fix the config_compat script and I agree with you that > it is difficult for you because of the various Kernels and distributions you > have to maintain. > > Then your workar

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Jasmin J.
Hello Brad! THX for this clarification! So you tried already to fix the config_compat script and I agree with you that it is difficult for you because of the various Kernels and distributions you have to maintain. Then your workaround is indeed a possibility to use media-build to build your modu

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Brad Love
Hi Jasmin, On 2018-05-11 15:02, Jasmin J. wrote: > Hello Brad! > >> and which the media_build system does not pick up on for whatever >> reason. > Maybe it would be better to analyse why "make_config_compat.pl" selects > wrongly the compatibility code. I've found several reasons, but the one I s

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Jasmin J.
Hello Brad! > and which the media_build system does not pick up on for whatever > reason. Maybe it would be better to analyse why "make_config_compat.pl" selects wrongly the compatibility code. > It seems there is quite often at least one backport I must disable, > and some target kernels require

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Brad Love
Hi Hans, On 2018-05-11 10:11, Hans Verkuil wrote: > On 05/11/18 17:08, Brad Love wrote: >> Hi Hans, >> >> >> On 2018-05-11 09:41, Hans Verkuil wrote: >>> Hi Brad, >>> >>> On 04/26/18 19:19, Brad Love wrote: config-mycompat.h is for overriding macros which are incorrectly enabled on cert

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Hans Verkuil
On 05/11/18 17:08, Brad Love wrote: > Hi Hans, > > > On 2018-05-11 09:41, Hans Verkuil wrote: >> Hi Brad, >> >> On 04/26/18 19:19, Brad Love wrote: >>> config-mycompat.h is for overriding macros which are incorrectly >>> enabled on certain kernels by the build system. The file should be >>> left

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Brad Love
Hi Hans, On 2018-05-11 09:41, Hans Verkuil wrote: > Hi Brad, > > On 04/26/18 19:19, Brad Love wrote: >> config-mycompat.h is for overriding macros which are incorrectly >> enabled on certain kernels by the build system. The file should be >> left empty, unless build errors are encountered for a k

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Hans Verkuil
Hi Brad, On 04/26/18 19:19, Brad Love wrote: > config-mycompat.h is for overriding macros which are incorrectly > enabled on certain kernels by the build system. The file should be > left empty, unless build errors are encountered for a kernel. The > file is removed by distclean, therefore should

[PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-04-26 Thread Brad Love
config-mycompat.h is for overriding macros which are incorrectly enabled on certain kernels by the build system. The file should be left empty, unless build errors are encountered for a kernel. The file is removed by distclean, therefore should be externally sourced, before the build process starts