[PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-02 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com add OF support for the mt9p031 sensor driver. Alongside this patch sorts the header inclusion alphabetically. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: Laurent Pinchart

Re: [PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-02 Thread Sascha Hauer
On Thu, May 02, 2013 at 11:52:34AM +0530, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com add OF support for the mt9p031 sensor driver. Alongside this patch sorts the header inclusion alphabetically. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cc: Hans

Re: [PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-02 Thread Prabhakar Lad
Hi Sascha, Thanks for the quick review. On Thu, May 2, 2013 at 12:25 PM, Sascha Hauer s.ha...@pengutronix.de wrote: On Thu, May 02, 2013 at 11:52:34AM +0530, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com add OF support for the mt9p031 sensor driver. Alongside this

Re: [PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-02 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Thursday 02 May 2013 12:34:25 Prabhakar Lad wrote: On Thu, May 2, 2013 at 12:25 PM, Sascha Hauer wrote: On Thu, May 02, 2013 at 11:52:34AM +0530, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com add OF support for the

Re: [PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-02 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Thu, May 2, 2013 at 4:32 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, Thank you for the patch. On Thursday 02 May 2013 12:34:25 Prabhakar Lad wrote: On Thu, May 2, 2013 at 12:25 PM, Sascha Hauer wrote: On Thu, May 02,

Re: [PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-02 Thread Laurent Pinchart
Hi Prabhakar, On Thursday 02 May 2013 18:48:37 Prabhakar Lad wrote: On Thu, May 2, 2013 at 4:32 PM, Laurent Pinchart wrote: On Thursday 02 May 2013 12:34:25 Prabhakar Lad wrote: On Thu, May 2, 2013 at 12:25 PM, Sascha Hauer wrote: On Thu, May 02, 2013 at 11:52:34AM +0530, Prabhakar Lad

Re: [PATCH RFC v2] media: i2c: mt9p031: add OF support

2013-05-02 Thread Arnd Bergmann
On Thursday 02 May 2013 08:55:18 Sascha Hauer wrote: +#if defined(CONFIG_OF) +static struct mt9p031_platform_data * + mt9p031_get_pdata(struct i2c_client *client) + +{ + if (client-dev.of_node) { By inverting the logic here and returning immediately you can safe an