Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-06-18 Thread Laurent Pinchart
Hi Andrzej, Thank you for the patch. On Thursday 16 May 2013 10:14:33 Andrzej Hajda wrote: > This patch adds managed version of initialization > function for v4l2 control handler. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park Acked-by: Laur

Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-06-10 Thread Hans Verkuil
On Sun June 9 2013 20:05:33 Sylwester Nawrocki wrote: > Hi Sakari, > > On 06/06/2013 11:41 PM, Sakari Ailus wrote: > ... > >> diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c > >> b/drivers/media/v4l2-core/v4l2-ctrls.c > >> index ebb8e48..f47ccfa 100644 > >> --- a/drivers/media/v

Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-06-09 Thread Sylwester Nawrocki
Hi Sakari, On 06/06/2013 11:41 PM, Sakari Ailus wrote: ... diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index ebb8e48..f47ccfa 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls.c +++ b/drivers/media/v4l2-core/v4l2-ctrls.c @@ -1421,6 +1421,38 @@ void v4l

Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-06-06 Thread Sakari Ailus
Hi Andrzej and Hans, On Fri, May 31, 2013 at 09:59:11AM +0200, Hans Verkuil wrote: > On Fri May 31 2013 03:08:33 Sakari Ailus wrote: > > Hi Hans, > > > > Hans Verkuil wrote: > > > On Fri 17 May 2013 00:34:51 Sakari Ailus wrote: > > >> Hi Andrzej, > > >> > > >> Thanks for the patchset! > > >> > >

Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-05-31 Thread Hans Verkuil
On Fri May 31 2013 03:08:33 Sakari Ailus wrote: > Hi Hans, > > Hans Verkuil wrote: > > On Fri 17 May 2013 00:34:51 Sakari Ailus wrote: > >> Hi Andrzej, > >> > >> Thanks for the patchset! > >> > >> On Thu, May 16, 2013 at 10:14:33AM +0200, Andrzej Hajda wrote: > >>> This patch adds managed version

Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-05-30 Thread Sakari Ailus
Hi Andrzej, Andrzej Hajda wrote: I have to say I don't think it's neither meaningful to acquire that mutex in v4l2_ctrl_handler_free(), though, since the whole going to be freed next anyway: reference counting would be needed to prevent bad things from happening, in case the drivers wouldn't tak

Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-05-30 Thread Sakari Ailus
Hi Hans, Hans Verkuil wrote: On Fri 17 May 2013 00:34:51 Sakari Ailus wrote: Hi Andrzej, Thanks for the patchset! On Thu, May 16, 2013 at 10:14:33AM +0200, Andrzej Hajda wrote: This patch adds managed version of initialization function for v4l2 control handler. Signed-off-by: Andrzej Hajda

Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-05-23 Thread Hans Verkuil
On Thu 16 May 2013 10:14:33 Andrzej Hajda wrote: > This patch adds managed version of initialization > function for v4l2 control handler. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park Acked-by: Hans Verkuil Regards, Hans > --- > v

Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-05-23 Thread Hans Verkuil
On Fri 17 May 2013 00:34:51 Sakari Ailus wrote: > Hi Andrzej, > > Thanks for the patchset! > > On Thu, May 16, 2013 at 10:14:33AM +0200, Andrzej Hajda wrote: > > This patch adds managed version of initialization > > function for v4l2 control handler. > > > > Signed-off-by: Andrzej Hajda > > Rev

Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-05-20 Thread Andrzej Hajda
Hi Sakari, Thanks for the review. On 17.05.2013 00:34, Sakari Ailus wrote: > Hi Andrzej, > > Thanks for the patchset! > > On Thu, May 16, 2013 at 10:14:33AM +0200, Andrzej Hajda wrote: >> This patch adds managed version of initialization >> function for v4l2 control handler. >> >> Signed-off-by:

Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-05-16 Thread Sakari Ailus
Hi Andrzej, Thanks for the patchset! On Thu, May 16, 2013 at 10:14:33AM +0200, Andrzej Hajda wrote: > This patch adds managed version of initialization > function for v4l2 control handler. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park > ---

[PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-05-16 Thread Andrzej Hajda
This patch adds managed version of initialization function for v4l2 control handler. Signed-off-by: Andrzej Hajda Reviewed-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- v3: - removed managed cleanup v2: - added missing struct device forward declaration, - corre