Re: [PATCH RFC v3 6/7] rtl2832_sdr: convert to SDR API

2013-12-19 Thread Hans Verkuil
On 12/16/2013 11:08 PM, Antti Palosaari wrote: It was abusing video device API. Use SDR API instead. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 291 ++- 1 file changed, 227 insertions(+), 64 deletions(-) A

Re: [PATCH RFC v3 6/7] rtl2832_sdr: convert to SDR API

2013-12-19 Thread Antti Palosaari
Hi Hans! On 19.12.2013 11:21, Hans Verkuil wrote: On 12/16/2013 11:08 PM, Antti Palosaari wrote: It was abusing video device API. Use SDR API instead. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 291 ++- 1 file

Re: [PATCH RFC v3 6/7] rtl2832_sdr: convert to SDR API

2013-12-19 Thread Devin Heitmueller
I haven't looked situation more carefully yet, but one thing that must be done at the very first is to add some lock to prevent only DVB or V4L2 API could access the hardware at time. Probably worth mentioning that we have *lots* of devices that suffer from this problem. Our general tact has

Re: [PATCH RFC v3 6/7] rtl2832_sdr: convert to SDR API

2013-12-19 Thread Antti Palosaari
On 19.12.2013 18:59, Devin Heitmueller wrote: I haven't looked situation more carefully yet, but one thing that must be done at the very first is to add some lock to prevent only DVB or V4L2 API could access the hardware at time. Probably worth mentioning that we have *lots* of devices that

Re: [PATCH RFC v3 6/7] rtl2832_sdr: convert to SDR API

2013-12-19 Thread Devin Heitmueller
I think I could add some lock quite easily. I remember when I implemented cxd2820r DVB-T/T2/C demod driver and at the time it implements 2 frontends, one for DVB-T/T2 and one for DVB-C. I used shared lock to prevent access only for single fe at time. I think same solution works in that case

[PATCH RFC v3 6/7] rtl2832_sdr: convert to SDR API

2013-12-16 Thread Antti Palosaari
It was abusing video device API. Use SDR API instead. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 291 ++- 1 file changed, 227 insertions(+), 64 deletions(-) diff --git a/drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c

Re: [PATCH RFC v3 6/7] rtl2832_sdr: convert to SDR API

2013-12-16 Thread Hans Verkuil
On 12/16/2013 11:08 PM, Antti Palosaari wrote: It was abusing video device API. Use SDR API instead. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 291 ++- 1 file changed, 227 insertions(+), 64 deletions(-) diff