Re: [PATCH V2 1/3] saa7115: move the autodetection code out of the probe function

2013-05-05 Thread Mauro Carvalho Chehab
Em Sun, 5 May 2013 10:20:08 +0200 Jon Arne Jørgensen escreveu: > On Fri, May 03, 2013 at 09:08:16AM -0300, Mauro Carvalho Chehab wrote: > > Em 03-05-2013 08:20, Ezequiel Garcia escreveu: > > >Hi Jon, > > > > > >On Fri, May 03, 2013 at 08:58:46AM +0200, Jon Arne Jørgensen wrote: > > >[...] > > >>>

Re: [PATCH V2 1/3] saa7115: move the autodetection code out of the probe function

2013-05-05 Thread Jon Arne Jørgensen
On Fri, May 03, 2013 at 09:08:16AM -0300, Mauro Carvalho Chehab wrote: > Em 03-05-2013 08:20, Ezequiel Garcia escreveu: > >Hi Jon, > > > >On Fri, May 03, 2013 at 08:58:46AM +0200, Jon Arne Jørgensen wrote: > >[...] > >>>You can read more about this in Documentation/SubmittingPatches. > >> > >>I jus

Re: [PATCH V2 1/3] saa7115: move the autodetection code out of the probe function

2013-05-03 Thread Mauro Carvalho Chehab
Em 03-05-2013 08:20, Ezequiel Garcia escreveu: Hi Jon, On Fri, May 03, 2013 at 08:58:46AM +0200, Jon Arne Jørgensen wrote: [...] You can read more about this in Documentation/SubmittingPatches. I just re-read SubmittingPatches. I couldn't see that there is anything wrong with multiple sign-of

Re: [PATCH V2 1/3] saa7115: move the autodetection code out of the probe function

2013-05-03 Thread Mauro Carvalho Chehab
Em 03-05-2013 03:32, Jon Arne Jørgensen escreveu: On Thu, May 02, 2013 at 11:09:14PM -0300, Ezequiel Garcia wrote: Hi Jon, On Mon, Apr 29, 2013 at 10:41:07PM +0200, Jon Arne Jørgensen wrote: As we're now seeing other variants from chinese clones, like gm1113c, we'll need to add more bits at th

Re: [PATCH V2 1/3] saa7115: move the autodetection code out of the probe function

2013-05-03 Thread Ezequiel Garcia
Hi Jon, On Fri, May 03, 2013 at 08:58:46AM +0200, Jon Arne Jørgensen wrote: [...] > > You can read more about this in Documentation/SubmittingPatches. > > I just re-read SubmittingPatches. > I couldn't see that there is anything wrong with multiple sign-off's. > Indeed there isn't anything wron

Re: [PATCH V2 1/3] saa7115: move the autodetection code out of the probe function

2013-05-02 Thread Jon Arne Jørgensen
On Thu, May 02, 2013 at 11:09:14PM -0300, Ezequiel Garcia wrote: > Hi Jon, > > On Mon, Apr 29, 2013 at 10:41:07PM +0200, Jon Arne Jørgensen wrote: > > As we're now seeing other variants from chinese clones, like > > gm1113c, we'll need to add more bits at the detection code. > > > > So, move it i

Re: [PATCH V2 1/3] saa7115: move the autodetection code out of the probe function

2013-05-02 Thread Jon Arne Jørgensen
On Thu, May 02, 2013 at 11:09:14PM -0300, Ezequiel Garcia wrote: > Hi Jon, > > On Mon, Apr 29, 2013 at 10:41:07PM +0200, Jon Arne Jørgensen wrote: > > As we're now seeing other variants from chinese clones, like > > gm1113c, we'll need to add more bits at the detection code. > > > > So, move it i

Re: [PATCH V2 1/3] saa7115: move the autodetection code out of the probe function

2013-05-02 Thread Ezequiel Garcia
Hi Jon, On Mon, Apr 29, 2013 at 10:41:07PM +0200, Jon Arne Jørgensen wrote: > As we're now seeing other variants from chinese clones, like > gm1113c, we'll need to add more bits at the detection code. > > So, move it into a separate function. > > Signed-off-by: Mauro Carvalho Chehab > Signed-of

[PATCH V2 1/3] saa7115: move the autodetection code out of the probe function

2013-04-29 Thread Jon Arne Jørgensen
As we're now seeing other variants from chinese clones, like gm1113c, we'll need to add more bits at the detection code. So, move it into a separate function. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Jon Arne Jørgensen --- drivers/media/i2c/saa7115.c | 133 ++