Re: [PATCH v1] [media] atmel-isi: code cleanup

On 5/22/2017 15:52, Hugues FRUCHET wrote: Hi Songjun, It was an advice from Hans, I copy/paste the comment here: http://www.mail-archive.com/linux-media@vger.kernel.org/msg112338.html >> + /* Enable stream on the sub device */ >> + ret = v4l2_subdev_call(dcmi->entity.subdev,

Re: [PATCH v1] [media] atmel-isi: code cleanup

Hi Songjun, It was an advice from Hans, I copy/paste the comment here: http://www.mail-archive.com/linux-media@vger.kernel.org/msg112338.html >> + /* Enable stream on the sub device */ >> + ret = v4l2_subdev_call(dcmi->entity.subdev, video, s_stream, 1); >> + if (ret && ret !=

Re: [PATCH v1] [media] atmel-isi: code cleanup

Hi Hugues, Thank you for your patch. Is it necessary to ensure ISI is clocked before starting sensor sub device? On 5/19/2017 20:08, Hugues FRUCHET wrote: Adding Songjun and Ludovic as Atmel maintainers, sorry for inconvenience. On 05/19/2017 12:04 PM, Hugues Fruchet wrote: Ensure that ISI

Re: [PATCH v1] [media] atmel-isi: code cleanup

Adding Songjun and Ludovic as Atmel maintainers, sorry for inconvenience. On 05/19/2017 12:04 PM, Hugues Fruchet wrote: > Ensure that ISI is clocked before starting sensor sub device. > Remove un-needed type check in try_fmt(). > Use clamp() macro for hardware capabilities. > Fix wrong tabulation

[PATCH v1] [media] atmel-isi: code cleanup

Ensure that ISI is clocked before starting sensor sub device. Remove un-needed type check in try_fmt(). Use clamp() macro for hardware capabilities. Fix wrong tabulation to space. Signed-off-by: Hugues Fruchet --- drivers/media/platform/atmel/atmel-isi.c | 24