Re: [PATCH v1 4/5] [media] stm32-dcmi: set default format at open()

2017-08-21 Thread Hugues FRUCHET
On 08/04/2017 02:00 PM, Hans Verkuil wrote: > On 28/07/17 12:05, Hugues Fruchet wrote: >> Ensure that we start with default pixel format and resolution >> when opening a new instance. > > Why? The format is persistent in V4L2 and (re)opening the video device > shouldn't change the format. > >

Re: [PATCH v1 4/5] [media] stm32-dcmi: set default format at open()

2017-08-04 Thread Hans Verkuil
On 28/07/17 12:05, Hugues Fruchet wrote: > Ensure that we start with default pixel format and resolution > when opening a new instance. Why? The format is persistent in V4L2 and (re)opening the video device shouldn't change the format. Suppose you use v4l2-ctl to set up a format. E.g. v4l2-ctl

[PATCH v1 4/5] [media] stm32-dcmi: set default format at open()

2017-07-28 Thread Hugues Fruchet
Ensure that we start with default pixel format and resolution when opening a new instance. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 49 ++- 1 file changed, 28 insertions(+), 21 deletions(-) diff --git