Re: [PATCH v1 7/7] v4l: videobuf2: add CMA allocator

2010-09-15 Thread han jonghun
Hello, In vb2_cma_put if buf-refcount is 0, cma_free is called. But vb2_cma_put is usually called from munmap. In my opinion cma_free should be called from VIDIOC_REQBUFS(0) not munmap. BRs, 2010/9/9 Pawel Osciak p.osc...@samsung.com: Add support for the CMA contiguous memory allocator to

Re: [PATCH v1 7/7] v4l: videobuf2: add CMA allocator

2010-09-15 Thread Pawel Osciak
Hello, On 09/15/2010 10:55 AM, han jonghun wrote: Hello, In vb2_cma_put if buf-refcount is 0, cma_free is called. But vb2_cma_put is usually called from munmap. In my opinion cma_free should be called from VIDIOC_REQBUFS(0) not munmap. cma_free has to be called from both, since we do not

[PATCH v1 7/7] v4l: videobuf2: add CMA allocator

2010-09-09 Thread Pawel Osciak
Add support for the CMA contiguous memory allocator to videobuf2. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/Kconfig |5 + drivers/media/video/Makefile|2 +