Hello,
On Sunday 25 November 2012 13:04:09 Sakari Ailus wrote:
Sylwester Nawrocki wrote:
On 11/14/2012 02:06 PM, Laurent Pinchart wrote:
...
+
+static DEFINE_MUTEX(clk_lock);
+static LIST_HEAD(v4l2_clk);
As Sylwester mentioned, what about s/v4l2_clk/v4l2_clks/ ?
Don't you
Hi Sylwester,
Sylwester Nawrocki wrote:
Hi All,
On 11/14/2012 02:06 PM, Laurent Pinchart wrote:
...
+
+static DEFINE_MUTEX(clk_lock);
+static LIST_HEAD(v4l2_clk);
As Sylwester mentioned, what about s/v4l2_clk/v4l2_clks/ ?
Don't you think naming of a static variable isn't important
Hi All,
On 11/14/2012 02:06 PM, Laurent Pinchart wrote:
...
+
+static DEFINE_MUTEX(clk_lock);
+static LIST_HEAD(v4l2_clk);
As Sylwester mentioned, what about s/v4l2_clk/v4l2_clks/ ?
Don't you think naming of a static variable isn't important enough?
;-) I think code authors should have
Hi Sakari,
On Tuesday 13 November 2012 01:37:51 Sakari Ailus wrote:
On Mon, Nov 12, 2012 at 12:06:50PM +0100, Laurent Pinchart wrote:
On Monday 12 November 2012 00:33:17 Sakari Ailus wrote:
On Wed, Oct 31, 2012 at 02:02:54PM +0100, Guennadi Liakhovetski wrote:
On Wed, 31 Oct 2012,
Hi Sakari,
On Monday 12 November 2012 00:33:17 Sakari Ailus wrote:
On Wed, Oct 31, 2012 at 02:02:54PM +0100, Guennadi Liakhovetski wrote:
On Wed, 31 Oct 2012, Laurent Pinchart wrote:
...
+#include linux/atomic.h
+#include linux/errno.h
+#include linux/list.h
+#include
Hi Laurent,
On Mon, Nov 12, 2012 at 12:06:50PM +0100, Laurent Pinchart wrote:
On Monday 12 November 2012 00:33:17 Sakari Ailus wrote:
On Wed, Oct 31, 2012 at 02:02:54PM +0100, Guennadi Liakhovetski wrote:
On Wed, 31 Oct 2012, Laurent Pinchart wrote:
...
+#include linux/atomic.h
Hi Guennadi,
Thanks for the patch!
On Wed, Oct 31, 2012 at 02:02:54PM +0100, Guennadi Liakhovetski wrote:
On Wed, 31 Oct 2012, Laurent Pinchart wrote:
...
+#include linux/atomic.h
+#include linux/errno.h
+#include linux/list.h
+#include linux/module.h
+#include linux/mutex.h
Hi Guennadi,
Thanks for the patch.
On Tuesday 30 October 2012 15:18:38 Guennadi Liakhovetski wrote:
Typical video devices like camera sensors require an external clock source.
Many such devices cannot even access their hardware registers without a
running clock. These clock sources should be
Hi Laurent
Thanks for the review
On Wed, 31 Oct 2012, Laurent Pinchart wrote:
Hi Guennadi,
Thanks for the patch.
On Tuesday 30 October 2012 15:18:38 Guennadi Liakhovetski wrote:
Typical video devices like camera sensors require an external clock source.
Many such devices cannot even
Typical video devices like camera sensors require an external clock source.
Many such devices cannot even access their hardware registers without a
running clock. These clock sources should be controlled by their consumers.
This should be performed, using the generic clock framework. Unfortunately
10 matches
Mail list logo
