Hi Guennadi,
> Well, I think, both of you will agree, that these register value lists
> look horrible and actually have little to do with open-source software,
> but I don't know what to do about them either. We could just reject them
> and only accept drivers, properly describing what they d
On Thu, 6 Jun 2013, jean-philippe francois wrote:
> 2013/6/5 Guennadi Liakhovetski :
> > Hi Phil
> >
> > Thanks for the patch. I'll look at it in more detail hopefully soon
> > enough... One remark so far to Jean-Philippe's comment:
> >
> > On Tue, 4 Jun 2013, jean-philippe francois wrote:
> >
> >
2013/6/5 Guennadi Liakhovetski :
> Hi Phil
>
> Thanks for the patch. I'll look at it in more detail hopefully soon
> enough... One remark so far to Jean-Philippe's comment:
>
> On Tue, 4 Jun 2013, jean-philippe francois wrote:
>
>> 2013/6/3 Phil Edworthy :
>> > Signed-off-by: Phil Edworthy
>> > --
Hi Guennadi,
> Thanks for the patch. I'll look at it in more detail hopefully soon
> enough... One remark so far to Jean-Philippe's comment:
>
[snip]
> > Register 0x3042 is only touched by the enable part, not by the "change
> > mode" part
> > I think you could move the {0x3042, 0xf0} sequence i
Hi Phil
Thanks for the patch. I'll look at it in more detail hopefully soon
enough... One remark so far to Jean-Philippe's comment:
On Tue, 4 Jun 2013, jean-philippe francois wrote:
> 2013/6/3 Phil Edworthy :
> > Signed-off-by: Phil Edworthy
> > ---
> > v2:
> > - Simplified flow in ov10635_s_
Hi Jean-Philippe,
Thanks for the review.
> > +static const struct ov10635_reg ov10635_regs_enable[] = {
> > + { 0x3042, 0xf0 }, { 0x3042, 0xf0 }, { 0x3042, 0xf0 }, {
> 0x3042, 0xf0 },
> > + { 0x3042, 0xf0 }, { 0x3042, 0xf0 }, { 0x3042, 0xf0 }, {
> 0x3042, 0xf0 },
> > + { 0x30
2013/6/3 Phil Edworthy :
> Signed-off-by: Phil Edworthy
> ---
> v2:
> - Simplified flow in ov10635_s_ctrl.
> - Removed chip ident code - build tested only
>
> drivers/media/i2c/soc_camera/Kconfig |6 +
> drivers/media/i2c/soc_camera/Makefile |1 +
> drivers/media/i2c/soc_camera/ov106
Signed-off-by: Phil Edworthy
---
v2:
- Simplified flow in ov10635_s_ctrl.
- Removed chip ident code - build tested only
drivers/media/i2c/soc_camera/Kconfig |6 +
drivers/media/i2c/soc_camera/Makefile |1 +
drivers/media/i2c/soc_camera/ov10635.c | 1141 ++
