Re: [PATCH v2 04/17] smiapp: Split off sub-device registration into two

2016-09-19 Thread Sebastian Reichel
Hi, On Mon, Sep 19, 2016 at 11:50:02PM +0300, Sakari Ailus wrote: > Hi Sebastian, > > Sebastian Reichel wrote: > > Hi, > > > > On Thu, Sep 15, 2016 at 02:22:18PM +0300, Sakari Ailus wrote: > > > Remove the loop in sub-device registration and create each sub-device > > > explicitly instead. > >

Re: [PATCH v2 04/17] smiapp: Split off sub-device registration into two

2016-09-19 Thread Sakari Ailus
Hi Sebastian, Sebastian Reichel wrote: Hi, On Thu, Sep 15, 2016 at 02:22:18PM +0300, Sakari Ailus wrote: Remove the loop in sub-device registration and create each sub-device explicitly instead. Reviewed-By: Sebastian Reichel Thanks! +static int smiapp_register_subdevs(struct smiapp_s

Re: [PATCH v2 04/17] smiapp: Split off sub-device registration into two

2016-09-19 Thread Sebastian Reichel
Hi, On Thu, Sep 15, 2016 at 02:22:18PM +0300, Sakari Ailus wrote: > Remove the loop in sub-device registration and create each sub-device > explicitly instead. Reviewed-By: Sebastian Reichel > +static int smiapp_register_subdevs(struct smiapp_sensor *sensor) > +{ > + int rval; > + > + i

[PATCH v2 04/17] smiapp: Split off sub-device registration into two

2016-09-15 Thread Sakari Ailus
Remove the loop in sub-device registration and create each sub-device explicitly instead. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 82 +++--- 1 file changed, 45 insertions(+), 37 deletions(-) diff --git a/drivers/media/i2c/smiapp/smiap