Re: [PATCH v2 1/2] media: davinci: vpif capture: upgrade the driver with v4l offerings

2014-04-04 Thread Hans Verkuil
Hi Prabhakar, Some review comments below. I'm going through the code quite carefully since this very nice cleanup is a good opportunity to check for correct behavior in this driver. On 04/04/2014 07:17 AM, Lad, Prabhakar wrote: > From: "Lad, Prabhakar" > > This patch upgrades the vpif display d

[PATCH v2 1/2] media: davinci: vpif capture: upgrade the driver with v4l offerings

2014-04-03 Thread Lad, Prabhakar
From: "Lad, Prabhakar" This patch upgrades the vpif display driver with v4l helpers, this patch does the following, 1: initialize the vb2 queue and context at the time of probe and removes context at remove() callback. 2: uses vb2_ioctl_*() helpers. 3: uses vb2_fop_*() helpers. 4: uses SIMPLE_DE