On Sun April 21 2013 20:40:30 Sergei Shtylyov wrote:
From: Vladimir Barinov vladimir.bari...@cogentembedded.com
Add OKI Semiconductor ML86V7667 video decoder driver.
Signed-off-by: Vladimir Barinov vladimir.bari...@cogentembedded.com
[Sergei: added v4l2_device_unregister_subdev() call to
Hi Hans,
Thank you for the review.
Hans Verkuil wrote:
+#include media/v4l2-chip-ident.h
This include should be removed as well.
ok
+
+static int ml86v7667_querystd(struct v4l2_subdev *sd, v4l2_std_id *std)
+{
+ struct ml86v7667_priv *priv = to_ml86v7667(sd);
+
+
On Mon April 22 2013 10:39:42 Vladimir Barinov wrote:
Hi Hans,
Thank you for the review.
Hans Verkuil wrote:
+#include media/v4l2-chip-ident.h
This include should be removed as well.
ok
+
+static int ml86v7667_querystd(struct v4l2_subdev *sd, v4l2_std_id *std)
Hi Hans,
Hans Verkuil wrote:
+*/
+ val = i2c_smbus_read_byte_data(client, STATUS_REG);
+ if (val 0)
+ return val;
+
+ priv-std = val STATUS_NTSCPAL ? V4L2_STD_PAL : V4L2_STD_NTSC;
Shouldn't this be 50 Hz vs 60 Hz formats? There are 60 Hz
Vladimir Barinov wrote:
Hi Hans,
Hans Verkuil wrote:
+ */
+val = i2c_smbus_read_byte_data(client, STATUS_REG);
+if (val 0)
+return val;
+
+priv-std = val STATUS_NTSCPAL ? V4L2_STD_PAL : V4L2_STD_NTSC;
Shouldn't this be 50 Hz vs 60 Hz formats? There are 60
From: Vladimir Barinov vladimir.bari...@cogentembedded.com
Add OKI Semiconductor ML86V7667 video decoder driver.
Signed-off-by: Vladimir Barinov vladimir.bari...@cogentembedded.com
[Sergei: added v4l2_device_unregister_subdev() call to the error cleanup path of
ml86v7667_probe(); some cleanup.]
