On 07/21/2016 11:49 AM, Hans Verkuil wrote:
>
>
> On 07/21/2016 09:30 AM, Jean Christophe TROTIN wrote:
>>
>> On 07/18/2016 01:45 PM, Hans Verkuil wrote:
>>> Hi Jean-Christophe,
>>>
>>> See my review comments below. Nothing really major, but I do need to know
>>> more
>>> about the g/s_parm and
On 07/21/2016 09:30 AM, Jean Christophe TROTIN wrote:
>
> On 07/18/2016 01:45 PM, Hans Verkuil wrote:
>> Hi Jean-Christophe,
>>
>> See my review comments below. Nothing really major, but I do need to know
>> more
>> about the g/s_parm and the restriction on the number of open()s has to be
>> l
On 07/18/2016 01:45 PM, Hans Verkuil wrote:
> Hi Jean-Christophe,
>
> See my review comments below. Nothing really major, but I do need to know more
> about the g/s_parm and the restriction on the number of open()s has to be
> lifted.
> That's not allowed.
>
Hi Hans,
Thank you for your comments
On 07/19/2016 05:55 PM, Jean Christophe TROTIN wrote:
> Hi Hans,
>
> Thank you for your comments.
> I've started to take them into account.
> I've got a question about V4L2_FIELD_ANY in buf_prepare (please see below).
>
> [snip]
>
> >> +static int hva_buf_prepare(struct vb2_buffer *vb)
> >> +{
Hi Hans,
Thank you for your comments.
I've started to take them into account.
I've got a question about V4L2_FIELD_ANY in buf_prepare (please see below).
[snip]
>> +static int hva_buf_prepare(struct vb2_buffer *vb)
>> +{
>> + struct hva_ctx *ctx = vb2_get_drv_priv(vb->vb2_queue);
>> +
Hi Jean-Christophe,
See my review comments below. Nothing really major, but I do need to know more
about the g/s_parm and the restriction on the number of open()s has to be
lifted.
That's not allowed.
On 07/11/2016 05:14 PM, Jean-Christophe Trotin wrote:
> This patch adds V4L2 HVA (Hardware Vide
On 07/11/2016 08:00 PM, Nicolas Dufresne wrote:
> Le lundi 11 juillet 2016 à 17:14 +0200, Jean-Christophe Trotin a écrit :
[snip]
>> +static int hva_g_fmt_stream(struct file *file, void *fh, struct v4l2_format
>> *f)
>> +{
>> +struct hva_ctx *ctx = fh_to_ctx(file->private_data);
>> +st
Le lundi 11 juillet 2016 à 17:14 +0200, Jean-Christophe Trotin a écrit :
> This patch adds V4L2 HVA (Hardware Video Accelerator) video encoder
> driver for STMicroelectronics SoC. It uses the V4L2 mem2mem framework.
>
> This patch only contains the core parts of the driver:
> - the V4L2 interface
This patch adds V4L2 HVA (Hardware Video Accelerator) video encoder
driver for STMicroelectronics SoC. It uses the V4L2 mem2mem framework.
This patch only contains the core parts of the driver:
- the V4L2 interface with the userland (hva-v4l2.c)
- the hardware services (hva-hw.c)
- the memory mana