Re: [PATCH v2 2/5] [media] exynos-mscl: Add core functionality for the M-Scaler driver

2013-08-29 Thread Sylwester Nawrocki
Hi Shaik, Couple more comments... On 08/19/2013 12:58 PM, Shaik Ameer Basha wrote: This patch adds the core functionality for the M-Scaler driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-mscl/mscl-core.c | 1312

Re: [PATCH v2 2/5] [media] exynos-mscl: Add core functionality for the M-Scaler driver

2013-08-20 Thread Hans Verkuil
On 08/20/2013 07:43 AM, Shaik Ameer Basha wrote: + linux-media, linux-samsung-soc Hi Hans, Thanks for the review. Will address all your comments in v3. I have only one doubt regarding try_ctrl... (addressed inline) On Mon, Aug 19, 2013 at 6:36 PM, Hans Verkuil hverk...@xs4all.nl

Re: [PATCH v2 2/5] [media] exynos-mscl: Add core functionality for the M-Scaler driver

2013-08-20 Thread Shaik Ameer Basha
On Tue, Aug 20, 2013 at 11:57 AM, Hans Verkuil hverk...@xs4all.nl wrote: On 08/20/2013 07:43 AM, Shaik Ameer Basha wrote: + linux-media, linux-samsung-soc Hi Hans, Thanks for the review. Will address all your comments in v3. I have only one doubt regarding try_ctrl... (addressed inline)

[PATCH v2 2/5] [media] exynos-mscl: Add core functionality for the M-Scaler driver

2013-08-19 Thread Shaik Ameer Basha
This patch adds the core functionality for the M-Scaler driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-mscl/mscl-core.c | 1312 drivers/media/platform/exynos-mscl/mscl-core.h | 549 ++ 2 files changed, 1861

Re: [PATCH v2 2/5] [media] exynos-mscl: Add core functionality for the M-Scaler driver

2013-08-19 Thread Hans Verkuil
On 08/19/2013 12:58 PM, Shaik Ameer Basha wrote: This patch adds the core functionality for the M-Scaler driver. Some more comments below... Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/media/platform/exynos-mscl/mscl-core.c | 1312

Re: [PATCH v2 2/5] [media] exynos-mscl: Add core functionality for the M-Scaler driver

2013-08-19 Thread Shaik Ameer Basha
+ linux-media, linux-samsung-soc Hi Hans, Thanks for the review. Will address all your comments in v3. I have only one doubt regarding try_ctrl... (addressed inline) On Mon, Aug 19, 2013 at 6:36 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 08/19/2013 12:58 PM, Shaik Ameer Basha wrote: