Re: [PATCH v2 21/21] em28xx: add module parameter for selection of the preferred USB transfer type

2012-12-23 Thread Mauro Carvalho Chehab
Em Sun, 23 Dec 2012 15:01:26 +0100 Frank Schäfer escreveu: > Am 23.12.2012 14:44, schrieb Mauro Carvalho Chehab: > > Hi Frank, > > > > Em Thu, 8 Nov 2012 20:11:53 +0200 > > Frank Schäfer escreveu: > > > >> By default, isoc transfers are used if possible. > >> With the new module parameter, bulk

Re: [PATCH v2 21/21] em28xx: add module parameter for selection of the preferred USB transfer type

2012-12-23 Thread Frank Schäfer
Am 23.12.2012 14:44, schrieb Mauro Carvalho Chehab: > Hi Frank, > > Em Thu, 8 Nov 2012 20:11:53 +0200 > Frank Schäfer escreveu: > >> By default, isoc transfers are used if possible. >> With the new module parameter, bulk can be selected as the >> preferred USB transfer type. > I did some tests ye

Re: [PATCH v2 21/21] em28xx: add module parameter for selection of the preferred USB transfer type

2012-12-23 Thread Mauro Carvalho Chehab
Hi Frank, Em Thu, 8 Nov 2012 20:11:53 +0200 Frank Schäfer escreveu: > By default, isoc transfers are used if possible. > With the new module parameter, bulk can be selected as the > preferred USB transfer type. I did some tests yesterday with prefer_bulk. IMHO, webcams should select bulk mode

Re: [PATCH v2 21/21] em28xx: add module parameter for selection of the preferred USB transfer type

2012-11-09 Thread Devin Heitmueller
On Fri, Nov 9, 2012 at 11:00 AM, Frank Schäfer wrote: > Well, I deliberately called the module 'prefer_bulk' (and not > 'use_bulk', 'force_bulk' ...) which should imply that nothing is guaranteed. > And selecting bulk transfers for a device which actually doesn not > provide bulk support doesn't m

Re: [PATCH v2 21/21] em28xx: add module parameter for selection of the preferred USB transfer type

2012-11-09 Thread Frank Schäfer
Am 08.11.2012 21:46, schrieb Devin Heitmueller: > On Thu, Nov 8, 2012 at 1:37 PM, Frank Schäfer > wrote: >> at least the "Silvercrest Webcam 1.3mpix" (board 71) exposes both >> endpoint types (0x82=isoc and 0x84=bulk). > Ah, interesting. It might be worthwhile to log a warning in dmesg if > the u

Re: [PATCH v2 21/21] em28xx: add module parameter for selection of the preferred USB transfer type

2012-11-08 Thread Devin Heitmueller
On Thu, Nov 8, 2012 at 1:37 PM, Frank Schäfer wrote: > at least the "Silvercrest Webcam 1.3mpix" (board 71) exposes both > endpoint types (0x82=isoc and 0x84=bulk). Ah, interesting. It might be worthwhile to log a warning in dmesg if the user sets the modprobe option but the board doesn't actual

Re: [PATCH v2 21/21] em28xx: add module parameter for selection of the preferred USB transfer type

2012-11-08 Thread Frank Schäfer
Am 08.11.2012 21:19, schrieb Devin Heitmueller: > On Thu, Nov 8, 2012 at 1:11 PM, Frank Schäfer > wrote: >> By default, isoc transfers are used if possible. >> With the new module parameter, bulk can be selected as the >> preferred USB transfer type. > Hi Frank, > > Does your device actually expos

Re: [PATCH v2 21/21] em28xx: add module parameter for selection of the preferred USB transfer type

2012-11-08 Thread Devin Heitmueller
On Thu, Nov 8, 2012 at 1:11 PM, Frank Schäfer wrote: > By default, isoc transfers are used if possible. > With the new module parameter, bulk can be selected as the > preferred USB transfer type. Hi Frank, Does your device actually expose both isoc and bulk endpoints? If I recall from the datas

[PATCH v2 21/21] em28xx: add module parameter for selection of the preferred USB transfer type

2012-11-08 Thread Frank Schäfer
By default, isoc transfers are used if possible. With the new module parameter, bulk can be selected as the preferred USB transfer type. Signed-off-by: Frank Schäfer --- drivers/media/usb/em28xx/em28xx-cards.c | 11 +-- 1 Datei geändert, 9 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) d