Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-07 Thread Tim Harvey
On Mon, Nov 6, 2017 at 11:47 PM, Hans Verkuil wrote: > On 11/07/2017 07:04 AM, Tim Harvey wrote: >> On Fri, Oct 20, 2017 at 7:00 AM, Tim Harvey wrote: >>> On Thu, Oct 19, 2017 at 12:39 AM, Hans Verkuil wrote: >>> > >

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-06 Thread Hans Verkuil
On 11/07/2017 07:04 AM, Tim Harvey wrote: > On Fri, Oct 20, 2017 at 7:00 AM, Tim Harvey wrote: >> On Thu, Oct 19, 2017 at 12:39 AM, Hans Verkuil wrote: >> Regarding video standard detection where this chip provides me with

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-06 Thread Tim Harvey
On Fri, Oct 20, 2017 at 7:00 AM, Tim Harvey wrote: > On Thu, Oct 19, 2017 at 12:39 AM, Hans Verkuil wrote: > >>> >>> Regarding video standard detection where this chip provides me with >>> vertical-period, horizontal-period, and horizontal-pulse-width

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-04 Thread Hans Verkuil
On 11/04/2017 01:17 AM, Tim Harvey wrote: > On Mon, Oct 23, 2017 at 10:05 AM, Tim Harvey wrote: >> >> On Fri, Oct 20, 2017 at 9:23 AM, Hans Verkuil wrote: >> I see the AVI infoframe has hdmi_quantization_range and

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-03 Thread Tim Harvey
On Mon, Oct 23, 2017 at 10:05 AM, Tim Harvey wrote: > > On Fri, Oct 20, 2017 at 9:23 AM, Hans Verkuil wrote: > > >> > >> I see the AVI infoframe has hdmi_quantization_range and > >> hdmi_ycc_quantization_range along with vid_code. > >> > >> I'm not at

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-10-23 Thread Tim Harvey
On Fri, Oct 20, 2017 at 9:23 AM, Hans Verkuil wrote: >> >> I see the AVI infoframe has hdmi_quantization_range and >> hdmi_ycc_quantization_range along with vid_code. >> >> I'm not at all clear what to do with this information. Is there >> anything you see in the datasheet

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-10-20 Thread Hans Verkuil
On 20/10/17 16:00, Tim Harvey wrote: > On Thu, Oct 19, 2017 at 12:39 AM, Hans Verkuil wrote: > What I am missing here is handling of the RGB quantization range. An HDMI receiver will typically send full range RGB or limited range YUV to the SoC. The HDMI source

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-10-20 Thread Tim Harvey
On Thu, Oct 19, 2017 at 12:39 AM, Hans Verkuil wrote: >>> What I am missing here is handling of the RGB quantization range. >>> An HDMI receiver will typically send full range RGB or limited range YUV >>> to the SoC. The HDMI source can however send full or limited range RGB

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-10-19 Thread Hans Verkuil
On 10/19/2017 09:20 AM, Tim Harvey wrote: > On Wed, Oct 18, 2017 at 5:04 AM, Hans Verkuil wrote: >> Hi Tim, >> >> Here is my review of this v2: >> >> On 10/12/17 06:45, Tim Harvey wrote: >>> Add support for the TDA1997x HDMI receivers. >>> > >>> + >>> +/* >>> + * Video Input

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-10-19 Thread Tim Harvey
On Wed, Oct 18, 2017 at 5:04 AM, Hans Verkuil wrote: > Hi Tim, > > Here is my review of this v2: > > On 10/12/17 06:45, Tim Harvey wrote: >> Add support for the TDA1997x HDMI receivers. >> >> + >> +/* >> + * Video Input formats >> + */ >> +struct vhref_values { >> + u16

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-10-19 Thread Hans Verkuil
On 10/18/2017 02:04 PM, Hans Verkuil wrote: > Hi Tim, > > Here is my review of this v2: > > On 10/12/17 06:45, Tim Harvey wrote: >> Add support for the TDA1997x HDMI receivers. >> >> Cc: Hans Verkuil >> Signed-off-by: Tim Harvey >> --- >> v2: >> -

Re: [PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-10-18 Thread Hans Verkuil
Hi Tim, Here is my review of this v2: On 10/12/17 06:45, Tim Harvey wrote: > Add support for the TDA1997x HDMI receivers. > > Cc: Hans Verkuil > Signed-off-by: Tim Harvey > --- > v2: > - implement dv timings enum/cap > - remove deprecated

[PATCH v2 3/4] media: i2c: Add TDA1997x HDMI receiver driver

2017-10-11 Thread Tim Harvey
Add support for the TDA1997x HDMI receivers. Cc: Hans Verkuil Signed-off-by: Tim Harvey --- v2: - implement dv timings enum/cap - remove deprecated g_mbus_config op - fix dv_query_timings - add EDID get/set handling - remove max-pixel-rate support