Re: [PATCH v2 3/4] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-06 Thread Philipp Zabel
On Thu, 2018-09-06 at 09:57 +0200, Hans Verkuil wrote: [...] > > If userspace sets xfer_func explicitly, it will get the explicit default > > ycbcr_enc and quantization values. > > > > I think I did this to make v4l2-compliance at some point, but it could > > be that the explicit output->capture c

Re: [PATCH v2 3/4] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-06 Thread Hans Verkuil
On 09/05/2018 03:20 PM, Philipp Zabel wrote: > On Wed, 2018-09-05 at 14:50 +0200, Hans Verkuil wrote: >>> +static enum v4l2_ycbcr_encoding pxp_default_ycbcr_enc(struct pxp_ctx *ctx) >>> +{ >>> + if (ctx->xfer_func) >>> + return V4L2_MAP_YCBCR_ENC_DEFAULT(ctx->colorspace); >>> + else

Re: [PATCH v2 3/4] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-05 Thread Philipp Zabel
Hi Fabio, On Wed, 2018-09-05 at 10:11 -0300, Fabio Estevam wrote: > Hi Philipp, > > On Wed, Sep 5, 2018 at 7:00 AM, Philipp Zabel wrote: > > > index ..2f90c692f3fe > > --- /dev/null > > +++ b/drivers/media/platform/imx-pxp.c > > @@ -0,0 +1,1774 @@ > > +// SPDX-License-Identifier: GP

Re: [PATCH v2 3/4] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-05 Thread Philipp Zabel
On Wed, 2018-09-05 at 14:50 +0200, Hans Verkuil wrote: [...] > > +config VIDEO_IMX_PXP > > + tristate "i.MX Pixel Pipeline (PXP)" > > + depends on VIDEO_DEV && VIDEO_V4L2 && (ARCH_MXC || COMPILE_TEST) > > + select VIDEOBUF2_DMA_CONTIG > > + select V4L2_MEM2MEM_DEV > > + help > > + Th

Re: [PATCH v2 3/4] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-05 Thread Fabio Estevam
Hi Philipp, On Wed, Sep 5, 2018 at 7:00 AM, Philipp Zabel wrote: > index ..2f90c692f3fe > --- /dev/null > +++ b/drivers/media/platform/imx-pxp.c > @@ -0,0 +1,1774 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later The recommended SPDX format in this case is: // SPDX-License-Identif

Re: [PATCH v2 3/4] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-05 Thread Hans Verkuil
On 09/05/18 12:00, Philipp Zabel wrote: > Add a V4L2 mem-to-mem scaler/CSC driver for the Pixel Pipeline (PXP) > version found on i.MX6ULL SoCs. A similar variant is used on i.MX7D. > > Since this driver only uses the legacy pipeline, it should be reasonably > easy to extend it to work with the ol

[PATCH v2 3/4] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-05 Thread Philipp Zabel
Add a V4L2 mem-to-mem scaler/CSC driver for the Pixel Pipeline (PXP) version found on i.MX6ULL SoCs. A similar variant is used on i.MX7D. Since this driver only uses the legacy pipeline, it should be reasonably easy to extend it to work with the older PXP versions found on i.MX6UL, i.MX6SX, i.MX6S