Re: [PATCH v2 3/4] media: ov2685: add support for OV2685 sensor

2018-01-31 Thread Sakari Ailus
Hi Shunqian, On Fri, Jan 12, 2018 at 10:30:57AM +0800, Shunqian Zheng wrote: > Hi Sakari, > > > On 2018年01月03日 19:43, Sakari Ailus wrote: > > > +static int ov2685_s_stream(struct v4l2_subdev *sd, int on) > > > +{ > > > + struct ov2685 *ov2685 = to_ov2685(sd); > > > + struct i2c_client *client =

Re: [PATCH v2 3/4] media: ov2685: add support for OV2685 sensor

2018-01-08 Thread Sakari Ailus
Hi Shunqian, On Mon, Jan 08, 2018 at 09:37:20PM +0800, Shunqian Zheng wrote: ... > > > +static int ov2685_probe(struct i2c_client *client, > > > + const struct i2c_device_id *id) > > > +{ > > > + struct device *dev = >dev; > > > + struct ov2685 *ov2685; > > > + int ret; > > > + >

Re: [PATCH v2 3/4] media: ov2685: add support for OV2685 sensor

2018-01-03 Thread Sakari Ailus
Hi Shunqian, Please see my comments below. On Fri, Dec 29, 2017 at 04:08:24PM +0800, Shunqian Zheng wrote: > This patch adds driver for Omnivision's ov2685 sensor. > Though the ov2685 can output yuv data, this driver only > supports the raw bayer format, including the following features: > -

[PATCH v2 3/4] media: ov2685: add support for OV2685 sensor

2017-12-29 Thread Shunqian Zheng
This patch adds driver for Omnivision's ov2685 sensor. Though the ov2685 can output yuv data, this driver only supports the raw bayer format, including the following features: - output 1600x1200 at 30fps - test patterns - manual exposure/gain control - vblank and hblank - media