Re: [PATCH v2 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

2017-12-20 Thread Lad, Prabhakar
Hi Mauro, Thanks for the patch. On Tue, Dec 19, 2017 at 11:18 AM, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn'

Re: [PATCH v2 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

2017-12-20 Thread Niklas Söderlund
Hi Mauro, On 2017-12-19 09:18:19 -0200, Mauro Carvalho Chehab wrote: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME > match criteria requires just a device name. > > So, it doesn't make sense to enclose tho

RE: [PATCH v2 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

2017-12-19 Thread Hyun Kwon
; Hugues Fruchet > ; Gustavo A. R. Silva > ; Sebastian Reichel ; Tomasz > Figa ; linux-arm-ker...@lists.infradead.org; linux- > samsung-...@vger.kernel.org; linux-renesas-...@vger.kernel.org; > de...@driverdev.osuosl.org > Subject: [PATCH v2 3/8] media: v4l2-async: simplify v4l2_asy

[PATCH v2 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

2017-12-19 Thread Mauro Carvalho Chehab
The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME match criteria requires just a device name. So, it doesn't make sense to enclose those into structs, as the criteria can go directly into the union. That makes eas