Re: [PATCH v2 4/4] media: v4l2-compat-ioctl32: better document the code

On 04/20/18 13:44, Mauro Carvalho Chehab wrote: > Em Fri, 20 Apr 2018 13:16:00 +0200 > Hans Verkuil escreveu: > > Thanks for the review! > >>> +/** >>> + * do_video_ioctl() - Ancillary function with handles a compat32 ioctl call >>> + * >>> + * @file: pointer to file with

Re: [PATCH v2 4/4] media: v4l2-compat-ioctl32: better document the code

Em Fri, 20 Apr 2018 13:16:00 +0200 Hans Verkuil escreveu: Thanks for the review! > > +/** > > + * do_video_ioctl() - Ancillary function with handles a compat32 ioctl call > > + * > > + * @file: pointer to file with the file handler > > + * @cmd: ioctl to be called > > + *

Re: [PATCH v2 4/4] media: v4l2-compat-ioctl32: better document the code

Hi Mauro, A bunch of typo, grammar and style fixes below. Looks good otherwise. On 04/19/18 18:33, Mauro Carvalho Chehab wrote: > This file does a lot of non-trivial struff. Document it using > kernel-doc markups where needed and improve the comments inside > do_video_ioctl(). > >

Re: [PATCH v2 4/4] media: v4l2-compat-ioctl32: better document the code

Em Thu, 19 Apr 2018 12:33:32 -0400 Mauro Carvalho Chehab escreveu: > This file does a lot of non-trivial struff. Document it using > kernel-doc markups where needed and improve the comments inside > do_video_ioctl(). Sent it too fast. It should be merged with this

[PATCH v2 4/4] media: v4l2-compat-ioctl32: better document the code

This file does a lot of non-trivial struff. Document it using kernel-doc markups where needed and improve the comments inside do_video_ioctl(). Signed-off-by: Mauro Carvalho Chehab --- drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 166 +- 1