Re: [PATCH v2 4/9] phy: dphy: Add configuration helpers

2018-12-04 Thread Maxime Ripard
On Tue, Dec 04, 2018 at 11:28:37AM +0530, Kishon Vijay Abraham I wrote: > Hi Maxime, > > On 21/11/18 3:03 PM, Maxime Ripard wrote: > > Hi Sakari, > > > > Thanks for your review. > > > > On Mon, Nov 19, 2018 at 03:43:57PM +0200, Sakari Ailus wrote: > >>> +/* > >>> + * Minimum D-PHY timings based

Re: [PATCH v2 4/9] phy: dphy: Add configuration helpers

2018-12-03 Thread Kishon Vijay Abraham I
Hi Maxime, On 21/11/18 3:03 PM, Maxime Ripard wrote: > Hi Sakari, > > Thanks for your review. > > On Mon, Nov 19, 2018 at 03:43:57PM +0200, Sakari Ailus wrote: >>> +/* >>> + * Minimum D-PHY timings based on MIPI D-PHY specification. Derived >>> + * from the valid ranges specified in Section 6.9,

Re: [PATCH v2 4/9] phy: dphy: Add configuration helpers

2018-11-21 Thread Maxime Ripard
Hi Sakari, Thanks for your review. On Mon, Nov 19, 2018 at 03:43:57PM +0200, Sakari Ailus wrote: > > +/* > > + * Minimum D-PHY timings based on MIPI D-PHY specification. Derived > > + * from the valid ranges specified in Section 6.9, Table 14, Page 41 > > + * of the D-PHY specification (v2.1). >

Re: [PATCH v2 4/9] phy: dphy: Add configuration helpers

2018-11-19 Thread Sakari Ailus
Hi Maxime, Apologies for the delayed review. Please see my comments below. On Tue, Nov 06, 2018 at 03:54:16PM +0100, Maxime Ripard wrote: > The MIPI D-PHY spec defines default values and boundaries for most of the > parameters it defines. Introduce helpers to help drivers get meaningful > values

[PATCH v2 4/9] phy: dphy: Add configuration helpers

2018-11-06 Thread Maxime Ripard
The MIPI D-PHY spec defines default values and boundaries for most of the parameters it defines. Introduce helpers to help drivers get meaningful values based on their current parameters, and validate the boundaries of these parameters if needed. Signed-off-by: Maxime Ripard --- drivers/phy/Kcon