Re: [PATCH v2 5/5] media: atmel-isc: Rework the format list

2017-09-27 Thread Yang, Wenyou
On 2017/9/27 16:03, Hans Verkuil wrote: On 09/27/2017 07:15 AM, Yang, Wenyou wrote: Hi Hans, Thank  you very much for your review. On 2017/9/25 21:24, Hans Verkuil wrote: Hi Wenyou, On 18/09/17 08:39, Wenyou Yang wrote: To improve the readability of code, split the format array into two,

Re: [PATCH v2 5/5] media: atmel-isc: Rework the format list

2017-09-27 Thread Hans Verkuil
On 09/27/2017 07:15 AM, Yang, Wenyou wrote: > Hi Hans, > > Thank  you very much for your review. > > On 2017/9/25 21:24, Hans Verkuil wrote: >> Hi Wenyou, >> >> On 18/09/17 08:39, Wenyou Yang wrote: >>> To improve the readability of code, split the format array into two, >>> one for the format de

Re: [PATCH v2 5/5] media: atmel-isc: Rework the format list

2017-09-26 Thread Yang, Wenyou
Hi Hans, Thank  you very much for your review. On 2017/9/25 21:24, Hans Verkuil wrote: Hi Wenyou, On 18/09/17 08:39, Wenyou Yang wrote: To improve the readability of code, split the format array into two, one for the format description, other for the register configuration. Meanwhile, add the

Re: [PATCH v2 5/5] media: atmel-isc: Rework the format list

2017-09-25 Thread Hans Verkuil
Hi Wenyou, On 18/09/17 08:39, Wenyou Yang wrote: > To improve the readability of code, split the format array into two, > one for the format description, other for the register configuration. > Meanwhile, add the flag member to indicate the format can be achieved > from the sensor or be produced b

[PATCH v2 5/5] media: atmel-isc: Rework the format list

2017-09-17 Thread Wenyou Yang
To improve the readability of code, split the format array into two, one for the format description, other for the register configuration. Meanwhile, add the flag member to indicate the format can be achieved from the sensor or be produced by the controller, and rename members related to the regist