Re: [PATCH v2 6/8] v4l: vsp1: Add support for the DISCOM entity

2018-04-28 Thread Kieran Bingham
Hi Laurent, On 22/04/18 23:34, Laurent Pinchart wrote: > The DISCOM calculates a CRC on a configurable window of the frame. It > interfaces to the VSP through the UIF glue, hence the name used in the > code. > > The module supports configuration of the CRC window through the crop > rectangle on

Re: [PATCH v2 6/8] v4l: vsp1: Add support for the DISCOM entity

2018-04-28 Thread Laurent Pinchart
Hi Jacopo, On Saturday, 28 April 2018 13:40:02 EEST jacopo mondi wrote: > HI Laurent, >a few comments, mostly minor ones... > > On Mon, Apr 23, 2018 at 01:34:28AM +0300, Laurent Pinchart wrote: > > The DISCOM calculates a CRC on a configurable window of the frame. It > > interfaces to the

Re: [PATCH v2 6/8] v4l: vsp1: Add support for the DISCOM entity

2018-04-28 Thread jacopo mondi
HI Laurent, a few comments, mostly minor ones... On Mon, Apr 23, 2018 at 01:34:28AM +0300, Laurent Pinchart wrote: > The DISCOM calculates a CRC on a configurable window of the frame. It > interfaces to the VSP through the UIF glue, hence the name used in the > code. > > The module supports

[PATCH v2 6/8] v4l: vsp1: Add support for the DISCOM entity

2018-04-22 Thread Laurent Pinchart
The DISCOM calculates a CRC on a configurable window of the frame. It interfaces to the VSP through the UIF glue, hence the name used in the code. The module supports configuration of the CRC window through the crop rectangle on the ink pad of the corresponding entity. However, unlike the