Re: [PATCH v2 7/8] [media] V4L: Add VP8 encoder controls

2013-06-24 Thread Arun Kumar K
Hi Sylwester, Thank you for the review. On Mon, Jun 24, 2013 at 2:23 AM, Sylwester Nawrocki wrote: > Hi Arun, > > > On 06/18/2013 02:56 PM, Arun Kumar K wrote: >> >> This patch adds new V4L controls for VP8 encoding. >> >> Signed-off-by: Arun Kumar K >> Signed-off-by: Kiran AVND > > > I think yo

Re: [PATCH v2 7/8] [media] V4L: Add VP8 encoder controls

2013-06-23 Thread Sylwester Nawrocki
On 06/23/2013 10:53 PM, Sylwester Nawrocki wrote: @@ -558,7 +566,23 @@ EXPORT_SYMBOL(v4l2_ctrl_get_menu); */ const s64 const *v4l2_ctrl_get_int_menu(u32 id, u32 *len) { [...] Then this would became: return __v4l2_qmenu_int_len(qmenu_int_vpx_num_partitions, &len); erratum: return __v4l2_qm

Re: [PATCH v2 7/8] [media] V4L: Add VP8 encoder controls

2013-06-23 Thread Sylwester Nawrocki
Hi Arun, On 06/18/2013 02:56 PM, Arun Kumar K wrote: This patch adds new V4L controls for VP8 encoding. Signed-off-by: Arun Kumar K Signed-off-by: Kiran AVND I think your signed-off-by should be last one, since you're submitting the patch. --- Documentation/DocBook/media/v4l/controls.xml

[PATCH v2 7/8] [media] V4L: Add VP8 encoder controls

2013-06-18 Thread Arun Kumar K
This patch adds new V4L controls for VP8 encoding. Signed-off-by: Arun Kumar K Signed-off-by: Kiran AVND --- Documentation/DocBook/media/v4l/controls.xml | 151 ++ drivers/media/v4l2-core/v4l2-ctrls.c | 36 ++ include/uapi/linux/v4l2-controls.h |