Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-06-26 Thread Mikhail Ulyanov
2015-06-26 15:14 GMT+03:00 Kamil Debski : > Hi Mikhail, > > On 26 June 2015 at 12:34, Mikhail Ulyanov > wrote: >> Hi, >> >> Thanks everybody for comments. >> >> 2015-06-22 17:54 GMT+03:00 Kamil Debski : >>> Hi, >>> >>> I am adding Jacek Anaszewski to CC loop. He was working with the >>> s5p-jpeg d

Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-06-26 Thread Kamil Debski
Hi Mikhail, On 26 June 2015 at 12:34, Mikhail Ulyanov wrote: > Hi, > > Thanks everybody for comments. > > 2015-06-22 17:54 GMT+03:00 Kamil Debski : >> Hi, >> >> I am adding Jacek Anaszewski to CC loop. He was working with the >> s5p-jpeg driver some time ago. >> I've spoken with him about questio

Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-06-26 Thread Mikhail Ulyanov
Hi, Thanks everybody for comments. 2015-06-22 17:54 GMT+03:00 Kamil Debski : > Hi, > > I am adding Jacek Anaszewski to CC loop. He was working with the > s5p-jpeg driver some time ago. > I've spoken with him about questions in this email recently. Jacek, > thank you for your comments :) > > On 18

Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-06-22 Thread Kamil Debski
Hi, I am adding Jacek Anaszewski to CC loop. He was working with the s5p-jpeg driver some time ago. I've spoken with him about questions in this email recently. Jacek, thank you for your comments :) On 18 June 2015 at 20:48, Laurent Pinchart wrote: > Hi Mikhail, > > (CC'ing Kamil Debski) > > On

Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-06-18 Thread Laurent Pinchart
Hi Mikhail, (CC'ing Kamil Debski) On Wednesday 06 May 2015 01:03:10 Mikhail Ulianov wrote: > On Mon, 04 May 2015 02:32:05 +0300 Laurent Pinchart wrote: > >> +/* > >> + * > >> + * video ioctl operations > >> + * =

Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-05-05 Thread Mikhail Ulianov
On Mon, 04 May 2015 02:32:05 +0300 Laurent Pinchart wrote: > Hi Mikhail, > > Thank you for the patch. Please see below for a (partial) review. > > On Thursday 30 April 2015 00:53:29 Mikhail Ulyanov wrote: > > Here's the the driver for the Renesas R-Car JPEG processing unit > > driver. > > > >

Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-05-05 Thread Mikhail Ulianov
Hello Laurent, Thanks for your comments. On Mon, 04 May 2015 02:32:05 +0300 Laurent Pinchart wrote: > > +/* > > + * > > > > + * video ioctl operations > > + * > > =

Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-05-04 Thread Laurent Pinchart
Hi Mikhail, Thank you for the patch. Please see below for a (partial) review. On Thursday 30 April 2015 00:53:29 Mikhail Ulyanov wrote: > Here's the the driver for the Renesas R-Car JPEG processing unit driver. > > The driver is implemented within the V4L2 framework as a mem-to-mem device. > It

Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-05-03 Thread Hans Verkuil
Hi Mikhail, Thank you for the patch! I have one high-level comment: please rename the source to r-car-jpu.c. It's good practice to start with the SoC name since 'jpu' by itself is not very descriptive. I have a few more comments (mostly easy ones) below: On 04/29/2015 11:53 PM, Mikhail Ulyanov

Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-04-29 Thread Sergei Shtylyov
Hello. On 04/30/2015 12:59 AM, Sergei Shtylyov wrote: Here's the the driver for the Renesas R-Car JPEG processing unit driver. One "the" is enough. And one "driver" too, you probbaly forgot to remove the word at the end. The driver is implemented within the V4L2 framework as a mem-to-

Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-04-29 Thread Sergei Shtylyov
On 04/30/2015 12:53 AM, Mikhail Ulyanov wrote: Here's the the driver for the Renesas R-Car JPEG processing unit driver. One "the" is enough. And one "driver" too, you probbaly forgot to remove the word at the end. The driver is implemented within the V4L2 framework as a mem-to-mem devic

[PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-04-29 Thread Mikhail Ulyanov
Here's the the driver for the Renesas R-Car JPEG processing unit driver. The driver is implemented within the V4L2 framework as a mem-to-mem device. It presents two video nodes to userspace, one for the encoding part, and one for the decoding part. It was found that the only working mode for enc