Re: [PATCH v3 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-30 Thread Guennadi Liakhovetski
Hi Fabio Sorry for a late review, but On Tue, 9 Oct 2012, Fabio Estevam wrote: > Since mx27 transitioned to the commmon clock framework in 3.5, the correct way > to acquire the csi clock is to get csi_ahb and csi_per clocks separately. > > By not doing so the camera sensor does not probe correc

Re: [PATCH v3 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-24 Thread javier Martin
On 23 October 2012 00:17, Fabio Estevam wrote: > Hi Guennadi > > On Mon, Oct 22, 2012 at 7:07 PM, Guennadi Liakhovetski > wrote: >> ? I don't find a clock named "per" and associated with "mx2-camera.0" in >> arch/arm/mach-imx/clk-imx27.c. I only find it in clk-imx25.c. Does this >> mean, that thi

Re: [PATCH v3 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-22 Thread Fabio Estevam
Hi Guennadi On Mon, Oct 22, 2012 at 7:07 PM, Guennadi Liakhovetski wrote: > ? I don't find a clock named "per" and associated with "mx2-camera.0" in > arch/arm/mach-imx/clk-imx27.c. I only find it in clk-imx25.c. Does this > mean, that this your patch is for i.MX25? But you're saying it's for > i

Re: [PATCH v3 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-22 Thread Guennadi Liakhovetski
Hi Fabio On Tue, 9 Oct 2012, Fabio Estevam wrote: > Since mx27 transitioned to the commmon clock framework in 3.5, the correct way > to acquire the csi clock is to get csi_ahb and csi_per clocks separately. > > By not doing so the camera sensor does not probe correctly: > > soc-camera-pdrv soc-

[PATCH v3 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread Fabio Estevam
Since mx27 transitioned to the commmon clock framework in 3.5, the correct way to acquire the csi clock is to get csi_ahb and csi_per clocks separately. By not doing so the camera sensor does not probe correctly: soc-camera-pdrv soc-camera-pdrv.0: Probing soc-camera-pdrv.0 mx2-camera mx2-camera.0