Re: [PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-06 Thread Ricardo Ribalda Delgado
Here are the patches https://patchwork.linuxtv.org/patch/20668/ https://patchwork.linuxtv.org/patch/20669/ Thanks! On Wed, Nov 6, 2013 at 9:26 AM, Ricardo Ribalda Delgado wrote: > Hello Hans and Sywester > > I have just posted a new patch. I think it fits the suggestions from > both of you, p

Re: [PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-06 Thread Ricardo Ribalda Delgado
Hello Hans and Sywester I have just posted a new patch. I think it fits the suggestions from both of you, please take a look to it and please post any comment. I will also send a patch about the em28xx, to swap the lock order. Thanks for your comments On Mon, Nov 4, 2013 at 4:19 PM, Hans Verkui

Re: [PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-04 Thread Hans Verkuil
On 11/04/2013 03:24 PM, Sylwester Nawrocki wrote: > On 04/11/13 15:12, Hans Verkuil wrote: >> On 11/04/2013 02:54 PM, Ricardo Ribalda Delgado wrote: Hello Hans Thanks for your comments. Please take a look to v4 of this patch https://patchwork.linuxtv.org/patch/20529/ >

Re: [PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-04 Thread Sylwester Nawrocki
On 04/11/13 15:12, Hans Verkuil wrote: > On 11/04/2013 02:54 PM, Ricardo Ribalda Delgado wrote: >> > Hello Hans >> > >> > Thanks for your comments. >> > >> > Please take a look to v4 of this patch >> > https://patchwork.linuxtv.org/patch/20529/ >> > >> > On Mon, Nov 4, 2013 at 1:37 PM, Hans Verk

Re: [PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-04 Thread Hans Verkuil
On 11/04/2013 02:54 PM, Ricardo Ribalda Delgado wrote: > Hello Hans > > Thanks for your comments. > > Please take a look to v4 of this patch > https://patchwork.linuxtv.org/patch/20529/ > > On Mon, Nov 4, 2013 at 1:37 PM, Hans Verkuil wrote: >> On 11/02/2013 10:53 AM, Ricardo Ribalda Delgado wr

Re: [PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-04 Thread Sylwester Nawrocki
Hi, On 04/11/13 14:54, Ricardo Ribalda Delgado wrote: > Hello Hans > > Thanks for your comments. > > Please take a look to v4 of this patch > https://patchwork.linuxtv.org/patch/20529/ We're discussing v4 actually ;) > On Mon, Nov 4, 2013 at 1:37 PM, Hans Verkuil wrote: >> On 11/02/2013 10:53

Re: [PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-04 Thread Ricardo Ribalda Delgado
Hello Hans Thanks for your comments. Please take a look to v4 of this patch https://patchwork.linuxtv.org/patch/20529/ On Mon, Nov 4, 2013 at 1:37 PM, Hans Verkuil wrote: > On 11/02/2013 10:53 AM, Ricardo Ribalda Delgado wrote: >> From: Ricardo Ribalda >> >> vb2_fop_relase does not held the lo

Re: [PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-04 Thread Hans Verkuil
On 11/02/2013 10:53 AM, Ricardo Ribalda Delgado wrote: > From: Ricardo Ribalda > > vb2_fop_relase does not held the lock although it is modifying the > queue->owner field. > > This could lead to race conditions on the vb2_perform_io function > when multiple applications are accessing the video d

[PATCH v4] videobuf2: Add missing lock held on vb2_fop_relase

2013-11-02 Thread Ricardo Ribalda Delgado
From: Ricardo Ribalda vb2_fop_relase does not held the lock although it is modifying the queue->owner field. This could lead to race conditions on the vb2_perform_io function when multiple applications are accessing the video device via read/write API: [ 308.297741] BUG: unable to handle kernel