Re: [PATCH v4 1/2] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls

2015-03-16 Thread Hans Verkuil
On 03/09/2015 05:45 PM, Ricardo Ribalda Delgado wrote: Hello Back from holidays and back to this issue. Sorry for the delay. I'm not sure about Ricardo's use case, is it the one we've discussed on #v4l ? If so, and if I recall correctly, the idea was to perform an action with a

Re: [PATCH v4 1/2] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls

2015-03-09 Thread Ricardo Ribalda Delgado
Hello Back from holidays and back to this issue. Sorry for the delay. I'm not sure about Ricardo's use case, is it the one we've discussed on #v4l ? If so, and if I recall correctly, the idea was to perform an action with a parameter, and didn't require volatility. In my case, there is a

Re: [PATCH v4 1/2] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls

2015-02-23 Thread Laurent Pinchart
Hi Hans, On Monday 23 February 2015 10:06:10 Hans Verkuil wrote: On 02/17/2015 04:08 PM, Ricardo Ribalda Delgado wrote: Volatile controls can change their value outside the v4l-ctrl framework. We should ignore the cached written value of the ctrl when evaluating if we should run s_ctrl.

Re: [PATCH v4 1/2] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls

2015-02-23 Thread Hans Verkuil
Hi Ricardo, On 02/17/2015 04:08 PM, Ricardo Ribalda Delgado wrote: Volatile controls can change their value outside the v4l-ctrl framework. We should ignore the cached written value of the ctrl when evaluating if we should run s_ctrl. I've been thinking some more about this (also due to some

Re: [PATCH v4 1/2] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls

2015-02-23 Thread Ricardo Ribalda Delgado
Hello Hans and Laurent I understand volatile as a control that can change its value by the device. So in that sense I think that my control is volatile and writeable (ack by the user). The value written by the user is meaning-less in my usercase, but in another s it could be useful. I am

[PATCH v4 1/2] media/v4l2-ctrls: Always run s_ctrl on volatile ctrls

2015-02-17 Thread Ricardo Ribalda Delgado
Volatile controls can change their value outside the v4l-ctrl framework. We should ignore the cached written value of the ctrl when evaluating if we should run s_ctrl. Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- v4: Hans Verkuil: explicity set has_changed to false. and