Re: [PATCH v4 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-25 Thread Måns Rullgård
Marc Gonzalez writes: > On 25/09/2017 16:08, Måns Rullgård wrote: > >> Marc Gonzalez writes: >> >> Why did you put this way early now? Registering the device should be >> the last thing you do (LIKE I DID IT, DAMMIT). Otherwise something might >> try to use it

Re: [PATCH v4 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-25 Thread Marc Gonzalez
On 25/09/2017 16:08, Måns Rullgård wrote: > Marc Gonzalez writes: > > Why did you put this way early now? Registering the device should be > the last thing you do (LIKE I DID IT, DAMMIT). Otherwise something might > try to use it before it is fully configured. > >> +err =

Re: [PATCH v4 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-25 Thread Måns Rullgård
Marc Gonzalez writes: > From: Mans Rullgard > > The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. > > Signed-off-by: Marc Gonzalez > --- > Changes between v3 and v4 > * Add one line to Kconfig help

[PATCH v4 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-25 Thread Marc Gonzalez
From: Mans Rullgard The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. Signed-off-by: Marc Gonzalez --- Changes between v3 and v4 * Add one line to Kconfig help message * Add DRIVER_NAME macro * Move devm_request_irq() call to the end of