Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-10-04 Thread Sakari Ailus
Hi Ping-chung, On Thu, Sep 27, 2018 at 03:19:07AM +, Chen, Ping-chung wrote: > Hi, > > >-Original Message- > >From: Yeh, Andy > >Sent: Wednesday, September 26, 2018 11:19 PM > >To: Sakari Ailus ; Chen, Ping-chung > > > > >Hi Sakari, PC, > > >sensors that do need >digital gain

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-10-01 Thread Philippe De Muyter
Hi, On Mon, Oct 01, 2018 at 12:50:02PM +0200, Helmut Grohne wrote: > Hi Laurent, > > On Fri, Sep 28, 2018 at 03:49:38PM +0200, Laurent Pinchart wrote: > > I don't think we'll reach an agreement here if we don't start talking about > > real use cases. Would you have some to share ? > > Fair

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-10-01 Thread Helmut Grohne
Hi Laurent, On Fri, Sep 28, 2018 at 03:49:38PM +0200, Laurent Pinchart wrote: > I don't think we'll reach an agreement here if we don't start talking about > real use cases. Would you have some to share ? Fair enough, but at that point, we very much disconnect from the imx208 in the subject.

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-28 Thread Laurent Pinchart
Hi Helmut, On Friday, 21 September 2018 10:23:37 EEST Helmut Grohne wrote: > On Thu, Sep 20, 2018 at 11:00:26PM +0200, Laurent Pinchart wrote: > > On Thursday, 20 September 2018 23:16:47 EEST Sylwester Nawrocki wrote: > >> On 09/20/2018 06:49 PM, Grant Grundler wrote: > >>> On Thu, Sep 20, 2018

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-26 Thread Chen, Ping-chung
Hi, >-Original Message- >From: Yeh, Andy >Sent: Wednesday, September 26, 2018 11:19 PM >To: Sakari Ailus ; Chen, Ping-chung > >Hi Sakari, PC, >sensors that do need >digital gain applied, too --- assuming it'd be >combined with the TRY_EXT_CTRLS rounding flags. >> >> There might be

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-26 Thread Yeh, Andy
mail.com; linux-media me...@vger.kernel.org>; Yeh, Andy ; Lai, Jim >; grund...@chromium.org; Mani, Rajmohan > >Subject: Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver > >Hi Ping-chung, > >On Wed, Sep 26, 2018 at 02:27:01AM +, Chen, Ping-chung wrot

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-26 Thread Sakari Ailus
Hi Ping-chung, On Wed, Sep 26, 2018 at 02:27:01AM +, Chen, Ping-chung wrote: > Hi Sakari, > > >-Original Message- > >From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > >Sent: Wednesday, September 26, 2018 5:55 AM > > >Hi Ping-chung, > > >On Tue, Sep 25, 2018 at 10:17:48AM

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-25 Thread Chen, Ping-chung
Hi Sakari, >-Original Message- >From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] >Sent: Wednesday, September 26, 2018 5:55 AM >Hi Ping-chung, >On Tue, Sep 25, 2018 at 10:17:48AM +, Chen, Ping-chung wrote: >... > > > > Controls that have a documented unit use that unit ---

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-25 Thread Sakari Ailus
Hi Ping-chung, On Tue, Sep 25, 2018 at 10:17:48AM +, Chen, Ping-chung wrote: ... > > > > Controls that have a documented unit use that unit --- as long as > > > > that's the unit used by the hardware. If it's not, it tends to be > > > > that another unit is used but the user space has

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-25 Thread Chen, Ping-chung
Hi Sakari, >-Original Message- >From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] >Sent: Tuesday, September 25, 2018 5:25 PM >To: Chen, Ping-chung >Cc: Ricardo Ribalda Delgado ; Laurent Pinchart >Subject: Re: [PATCH v5] media: imx208: Add imx208 camera senso

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-25 Thread Sakari Ailus
...@chromium.org; Sakari Ailus > ; sylwester.nawro...@gmail.com; linux-media > ; Yeh, Andy ; Lai, Jim > ; grund...@chromium.org; Mani, Rajmohan > > Subject: RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver > > Hi Sakari, > > >-Original Message-

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-21 Thread Helmut Grohne
On Thu, Sep 20, 2018 at 11:00:26PM +0200, Laurent Pinchart wrote: > On Thursday, 20 September 2018 23:16:47 EEST Sylwester Nawrocki wrote: > > On 09/20/2018 06:49 PM, Grant Grundler wrote: > > > On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: > > >> We have a problem here. The sensor supports

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-21 Thread Chen, Ping-chung
; Mani, Rajmohan Subject: RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver Hi Sakari, >-Original Message- >From: Ricardo Ribalda Delgado [mailto:ricardo.riba...@gmail.com] >Sent: Friday, September 21, 2018 5:55 AM >HI On Thu, Sep 20, 2018 at 11:13 PM Laurent Pinc

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-21 Thread Chen, Ping-chung
Hi Sakari, >-Original Message- >From: Ricardo Ribalda Delgado [mailto:ricardo.riba...@gmail.com] >Sent: Friday, September 21, 2018 5:55 AM >HI On Thu, Sep 20, 2018 at 11:13 PM Laurent Pinchart wrote: > > Hi Sakari, > > On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: >

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Ricardo Ribalda Delgado
HI On Thu, Sep 20, 2018 at 11:13 PM Laurent Pinchart wrote: > > Hi Sakari, > > On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: > > On Thu, Sep 20, 2018 at 05:51:55PM +0900, Tomasz Figa wrote: > > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: > > > [snip] > > > > > > > +

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Laurent Pinchart
Hi Sakari, On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: > On Thu, Sep 20, 2018 at 05:51:55PM +0900, Tomasz Figa wrote: > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: > > [snip] > > > > > + > > > +/* Digital gain control */ > > > +#define IMX208_REG_GR_DIGITAL_GAIN

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Laurent Pinchart
Hello, (CC'ing Helmut Grohne) On Thursday, 20 September 2018 23:16:47 EEST Sylwester Nawrocki wrote: > On 09/20/2018 06:49 PM, Grant Grundler wrote: > > On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: > >> On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: > >>> +/* Digital gain control */

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Sakari Ailus
Hi Tomasz, On Thu, Sep 20, 2018 at 05:51:55PM +0900, Tomasz Figa wrote: > [+Laurent and Sylwester] > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen > wrote: > [snip] > > + > > +/* Digital gain control */ > > +#define IMX208_REG_GR_DIGITAL_GAIN 0x020e > > +#define IMX208_REG_R_DIGITAL_GAIN

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Sylwester Nawrocki
On 09/20/2018 06:49 PM, Grant Grundler wrote: > On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: >> On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen >> wrote: >>> +/* Digital gain control */ >>> +#define IMX208_DGTL_GAIN_MIN 0 >>> +#define IMX208_DGTL_GAIN_MAX 4096 >>>

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Grant Grundler
[resend in plain text - sorry!] On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: > > [+Laurent and Sylwester] > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen > wrote: > [snip] > > + > > +/* Digital gain control */ > > +#define IMX208_REG_GR_DIGITAL_GAIN 0x020e > > +#define

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Tomasz Figa
[+Laurent and Sylwester] On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: [snip] > + > +/* Digital gain control */ > +#define IMX208_REG_GR_DIGITAL_GAIN 0x020e > +#define IMX208_REG_R_DIGITAL_GAIN 0x0210 > +#define IMX208_REG_B_DIGITAL_GAIN 0x0212 > +#define

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-18 Thread Sakari Ailus
Hi Grant, On Mon, Sep 17, 2018 at 03:52:30PM -0700, Grant Grundler wrote: > On Fri, Sep 14, 2018 at 4:41 AM Sakari Ailus > wrote: > > > > Hi Ping-chung, > > > > My apologies for the late review. > > Yeah...I had the impression this was already accepted. Though it > should be straight forward to

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-17 Thread Grant Grundler
On Fri, Sep 14, 2018 at 4:41 AM Sakari Ailus wrote: > > Hi Ping-chung, > > My apologies for the late review. Yeah...I had the impression this was already accepted. Though it should be straight forward to fix up additional things as normal patches. [sorry pruning heavily] ... > > +/* HBLANK

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-14 Thread Sakari Ailus
Hi Ping-chung, My apologies for the late review. On Wed, Aug 08, 2018 at 03:16:00PM +0800, Ping-chung Chen wrote: > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data.

[PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-08-08 Thread Ping-chung Chen
From: "Chen, Ping-chung" Add a V4L2 sub-device driver for the Sony IMX208 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Ping-Chung Chen Reviewed-by: Tomasz Figa --- since v1: -- Update the function media_entity_pads_init for