Re: [PATCH v5 01/11] media: ov5640: Adjust the clock based on the expected rate

2018-11-20 Thread jacopo mondi
Hi Maxime, On Tue, Nov 20, 2018 at 10:48:39AM +0100, Maxime Ripard wrote: > Hi Jacopo, > > On Wed, Nov 14, 2018 at 08:48:47PM +0100, jacopo mondi wrote: > > On Tue, Nov 13, 2018 at 02:03:15PM +0100, Maxime Ripard wrote: > > > The clock structure for the PCLK is quite obscure in the documentation,

Re: [PATCH v5 01/11] media: ov5640: Adjust the clock based on the expected rate

2018-11-20 Thread Maxime Ripard
Hi Jacopo, On Wed, Nov 14, 2018 at 08:48:47PM +0100, jacopo mondi wrote: > On Tue, Nov 13, 2018 at 02:03:15PM +0100, Maxime Ripard wrote: > > The clock structure for the PCLK is quite obscure in the documentation, and > > was hardcoded through the bytes array of each and every mode. > > > > This i

Re: [PATCH v5 01/11] media: ov5640: Adjust the clock based on the expected rate

2018-11-19 Thread Adam Ford
On Wed, Nov 14, 2018 at 7:20 AM Adam Ford wrote: > > On Tue, Nov 13, 2018 at 7:04 AM Maxime Ripard > wrote: > > > > The clock structure for the PCLK is quite obscure in the documentation, and > > was hardcoded through the bytes array of each and every mode. > > > > This is troublesome, since we

Re: [PATCH v5 01/11] media: ov5640: Adjust the clock based on the expected rate

2018-11-14 Thread jacopo mondi
Hi Maxime, many thanks for re-sending this updated version On Tue, Nov 13, 2018 at 02:03:15PM +0100, Maxime Ripard wrote: > The clock structure for the PCLK is quite obscure in the documentation, and > was hardcoded through the bytes array of each and every mode. > > This is troublesome, since

Re: [PATCH v5 01/11] media: ov5640: Adjust the clock based on the expected rate

2018-11-14 Thread Adam Ford
On Tue, Nov 13, 2018 at 7:04 AM Maxime Ripard wrote: > > The clock structure for the PCLK is quite obscure in the documentation, and > was hardcoded through the bytes array of each and every mode. > > This is troublesome, since we cannot adjust it at runtime based on other > parameters (such as th

[PATCH v5 01/11] media: ov5640: Adjust the clock based on the expected rate

2018-11-13 Thread Maxime Ripard
The clock structure for the PCLK is quite obscure in the documentation, and was hardcoded through the bytes array of each and every mode. This is troublesome, since we cannot adjust it at runtime based on other parameters (such as the number of bytes per pixel), and we can't support either framera