Re: [PATCH v5 2/2] media: ak7375: Add ak7375 lens voice coil driver

2018-06-21 Thread Bing Bu Cao
On 2018年06月21日 19:25, Sakari Ailus wrote: > On Tue, Jun 19, 2018 at 02:01:47PM +0800, bingbu@intel.com wrote: >> +static int ak7375_probe(struct i2c_client *client) >> +{ >> +struct ak7375_device *ak7375_dev; >> +int val; >> + >> +ak7375_dev = devm_kzalloc(&client->dev, sizeof(*a

Re: [PATCH v5 2/2] media: ak7375: Add ak7375 lens voice coil driver

2018-06-21 Thread Bing Bu Cao
On 2018年06月21日 19:23, Sakari Ailus wrote: > Hi Bingbu, > > On Tue, Jun 19, 2018 at 02:01:47PM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the ak7375 lens voice coil. >> This is a voice coil module using the i2c bus to control the >> focus positi

Re: [PATCH v5 2/2] media: ak7375: Add ak7375 lens voice coil driver

2018-06-21 Thread Sakari Ailus
On Tue, Jun 19, 2018 at 02:01:47PM +0800, bingbu@intel.com wrote: > +static int ak7375_probe(struct i2c_client *client) > +{ > + struct ak7375_device *ak7375_dev; > + int val; > + > + ak7375_dev = devm_kzalloc(&client->dev, sizeof(*ak7375_dev), > + GFP_

Re: [PATCH v5 2/2] media: ak7375: Add ak7375 lens voice coil driver

2018-06-21 Thread Sakari Ailus
Hi Bingbu, On Tue, Jun 19, 2018 at 02:01:47PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a v4l2 sub-device driver for the ak7375 lens voice coil. > This is a voice coil module using the i2c bus to control the > focus position. > > ak7375 can write multiple bytes of data at a

[PATCH v5 2/2] media: ak7375: Add ak7375 lens voice coil driver

2018-06-18 Thread bingbu . cao
From: Bingbu Cao Add a v4l2 sub-device driver for the ak7375 lens voice coil. This is a voice coil module using the i2c bus to control the focus position. ak7375 can write multiple bytes of data at a time. If more data is received instead of the stop condition after receiving one byte of data, t