Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-21 Thread Laurent Pinchart
Hi Sakari, On Friday 21 February 2014 15:04:48 Sakari Ailus wrote: > Hi Laurent, > > On Fri, Feb 21, 2014 at 12:58:58PM +0100, Laurent Pinchart wrote: > ... > > > > It's possible to calculate it (decrementing the readout time + exposure > > > time from the end of frame timestamp) and that's what

Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-21 Thread Sakari Ailus
Hi Laurent, On Fri, Feb 21, 2014 at 12:58:58PM +0100, Laurent Pinchart wrote: ... > > It's possible to calculate it (decrementing the readout time + exposure > > time from the end of frame timestamp) and that's what the devices > > supposedly do. The pre-frame exposure time isn't available to the

Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-21 Thread Laurent Pinchart
Hi Sakari, On Friday 21 February 2014 11:31:38 Sakari Ailus wrote: > Hans Verkuil wrote: > > On 02/20/2014 08:41 PM, Sakari Ailus wrote: > >> Some devices do not produce timestamps that correspond to the end of the > >> frame. The user space should be informed on the matter. This patch > >> achiev

Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-21 Thread Sakari Ailus
Hi Sylwester, Thanks for the comments. Sylwester Nawrocki wrote: ... On 02/20/2014 09:36 PM, Hans Verkuil wrote: On 02/20/2014 08:41 PM, Sakari Ailus wrote: Some devices do not produce timestamps that correspond to the end of the frame. The user space should be informed on the matter. This pa

Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-21 Thread Sakari Ailus
Hi Hans, Hans Verkuil wrote: On 02/20/2014 08:41 PM, Sakari Ailus wrote: Some devices do not produce timestamps that correspond to the end of the frame. The user space should be informed on the matter. This patch achieves that by adding buffer flags (and a mask) for timestamp sources since more

Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-20 Thread Hans Verkuil
On 02/21/2014 12:30 AM, Laurent Pinchart wrote: > Hi Hans, > > On Thursday 20 February 2014 21:36:51 Hans Verkuil wrote: >> On 02/20/2014 08:41 PM, Sakari Ailus wrote: >>> Some devices do not produce timestamps that correspond to the end of the >>> frame. The user space should be informed on the m

Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-20 Thread Laurent Pinchart
Hi Hans, On Thursday 20 February 2014 21:36:51 Hans Verkuil wrote: > On 02/20/2014 08:41 PM, Sakari Ailus wrote: > > Some devices do not produce timestamps that correspond to the end of the > > frame. The user space should be informed on the matter. This patch > > achieves > > that by adding buffe

Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-20 Thread Sylwester Nawrocki
On 02/20/2014 10:10 PM, Sylwester Nawrocki wrote: I would actually be inclined to drop it altogether for this particular timestamp source. But it's up to Laurent. Yup, the "a small amount of time" concept seems a bit vague here. It's not clear how long period it could be and the tolerance would

Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-20 Thread Sylwester Nawrocki
Hi Sakari, On 02/20/2014 09:36 PM, Hans Verkuil wrote: On 02/20/2014 08:41 PM, Sakari Ailus wrote: Some devices do not produce timestamps that correspond to the end of the frame. The user space should be informed on the matter. This patch achieves that by adding buffer flags (and a mask) for ti

Re: [PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-20 Thread Hans Verkuil
On 02/20/2014 08:41 PM, Sakari Ailus wrote: > Some devices do not produce timestamps that correspond to the end of the > frame. The user space should be informed on the matter. This patch achieves > that by adding buffer flags (and a mask) for timestamp sources since more > possible timestamping po

[PATCH v5.1 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-20 Thread Sakari Ailus
Some devices do not produce timestamps that correspond to the end of the frame. The user space should be informed on the matter. This patch achieves that by adding buffer flags (and a mask) for timestamp sources since more possible timestamping points are expected than just two. A three-bit mask i