Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-27 Thread Sakari Ailus
Hi Helen, Please see my comments below. Helen Koike wrote: > On 2017-01-25 11:03 AM, Sakari Ailus wrote: ... >>> + * the videobuf2 framework will allocate this struct based on >>> + * buf_struct_size and use the first sizeof(struct vb2_buffer) >>> bytes of >>> + * memory as a vb2_buff

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-24 Thread Helen Koike
Hi Sakari, Thanks for your review, I have some questions below: On 2017-01-25 11:03 AM, Sakari Ailus wrote: Hi Helen, My apologies for the long review time! Please see my comments below. On Sun, Sep 04, 2016 at 05:02:18PM -0300, Helen Koike wrote: From: Helen Fornazier First version of th

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-10 Thread Helen Koike
Hi Hans, On 2017-03-10 10:08 AM, Hans Verkuil wrote: Hi Helen, On 11/01/17 02:30, Helen Koike wrote: > > Thank you for the review, I'll update the patch accordingly and re-submit it. > > Helen Do you know when you have a v7 ready? Thanks for your interest. I don't have the next version entir

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-10 Thread Hans Verkuil
Hi Helen, On 11/01/17 02:30, Helen Koike wrote: > > Thank you for the review, I'll update the patch accordingly and re-submit it. > > Helen Do you know when you have a v7 ready? We really need a vimc driver so people without hardware can actually fiddle around with the MC. See also my rant h

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2017-01-25 Thread Mauro Carvalho Chehab
I won't be doing a review on it yet... I'll try to do it on the next version. Just a quick notice: Em Wed, 25 Jan 2017 15:03:46 +0200 Sakari Ailus escreveu: > > + * Copyright (C) 2016 Helen Koike F. > > 2017 might be used now. Please keep 2016 as the year you did the initial development. It

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2017-01-25 Thread Sakari Ailus
Hi Helen, My apologies for the long review time! Please see my comments below. On Sun, Sep 04, 2016 at 05:02:18PM -0300, Helen Koike wrote: > From: Helen Fornazier > > First version of the Virtual Media Controller. > Add a simple version of the core of the driver, the capture and > sensor node

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2017-01-10 Thread Helen Koike
Hi Laurent, On 2017-01-10 04:54 PM, Laurent Pinchart wrote: Hi Helen, (CC'ing Sakari as there's a question specifically for him) Thank you for the patch, and so sorry for the late review. On Sunday 04 Sep 2016 17:02:18 Helen Koike wrote: From: Helen Fornazier First version of the Virtual M

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2017-01-10 Thread Laurent Pinchart
Hi Helen, (CC'ing Sakari as there's a question specifically for him) Thank you for the patch, and so sorry for the late review. On Sunday 04 Sep 2016 17:02:18 Helen Koike wrote: > From: Helen Fornazier > > First version of the Virtual Media Controller. > Add a simple version of the core of th

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2016-09-06 Thread Hans Verkuil
On 09/04/16 22:02, Helen Koike wrote: From: Helen Fornazier First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Koike One thing is mi

[PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2016-09-04 Thread Helen Koike
From: Helen Fornazier First version of the Virtual Media Controller. Add a simple version of the core of the driver, the capture and sensor nodes in the topology, generating a grey image in a hardcoded format. Signed-off-by: Helen Koike --- Patch based in media/master tree, and available here