Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-25 Thread Sakari Ailus
Hi Bingbu, On Tue, Sep 25, 2018 at 05:10:59PM +0800, Bing Bu Cao wrote: ... > > +/* Initialize control handlers */ > > +static int imx319_init_controls(struct imx319 *imx319) > > +{ > > + struct i2c_client *client = v4l2_get_subdevdata(>sd); > > + struct

Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-25 Thread Bing Bu Cao
On 09/25/2018 03:33 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Tue, Sep 25, 2018 at 02:59:05PM +0800, Bing Bu Cao wrote: >> >> On 09/25/2018 11:57 AM, Bing Bu Cao wrote: >>> On 09/21/2018 08:06 PM, Sakari Ailus wrote: Hi Bingbu, On Fri, Sep 21, 2018 at 05:41:55PM +0800,

Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-25 Thread Sakari Ailus
Hi Bingbu, On Tue, Sep 25, 2018 at 02:59:05PM +0800, Bing Bu Cao wrote: > > > On 09/25/2018 11:57 AM, Bing Bu Cao wrote: > > > > On 09/21/2018 08:06 PM, Sakari Ailus wrote: > >> Hi Bingbu, > >> > >> On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: > >>> From: Bingbu Cao >

Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-25 Thread Bing Bu Cao
On 09/25/2018 11:57 AM, Bing Bu Cao wrote: > > On 09/21/2018 08:06 PM, Sakari Ailus wrote: >> Hi Bingbu, >> >> On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: >>> From: Bingbu Cao >>> >>> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >>> This is a camera

Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-24 Thread Bing Bu Cao
On 09/21/2018 08:06 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c bus for control and the >> csi-2

Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-22 Thread kbuild test robot
Hi Bingbu, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-21 Thread Sakari Ailus
Hi Bingbu, On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > This is a camera sensor using the i2c bus for control and the > csi-2 bus for data. > > This driver supports following

[PATCH v6] media: add imx319 camera sensor driver

2018-09-21 Thread bingbu . cao
From: Bingbu Cao Add a v4l2 sub-device driver for the Sony imx319 image sensor. This is a camera sensor using the i2c bus for control and the csi-2 bus for data. This driver supports following features: - manual exposure and analog/digital gain control support - vblank/hblank control support -